Fix eslint config next/core-web-vitals

[stefanprobst]

fixes what i messed up in #27363. cf. #27363 (comment)

also added an integration test for extending from next/core-web-vitals eslint config

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

Documentation / Examples

• Make sure the linting passes

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
buildDuration	13.4s	13.5s	⚠️ +104ms
buildDurationCached	3.1s	3s	-74ms
nodeModulesSize	50.3 MB	50.3 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.285	2.272	-0.01
/ avg req/sec	1094.25	1100.47	+6.22
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.293	1.28	-0.01
/error-in-render avg req/sec	1934.11	1953.16	+19.05

Client Bundles (main, webpack, commons)

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
745.HASH.js gzip	180 B	180 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	22.8 kB	22.8 kB	✓
webpack-HASH.js gzip	1.49 kB	1.49 kB	✓
Overall change	66.8 kB	66.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
_app-HASH.js gzip	980 B	980 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.52 kB	2.52 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	903 B	903 B	✓
image-HASH.js gzip	4.1 kB	4.1 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	319 B	319 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	12.8 kB	12.8 kB	✓

Client Build Manifests

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
_buildManifest.js gzip	490 B	490 B	✓
Overall change	490 B	490 B	✓

Rendered Page Sizes

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
index.html gzip	530 B	530 B	✓
link.html gzip	543 B	543 B	✓
withRouter.html gzip	523 B	523 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Webpack 4 Mode (Decrease detected ✓)

General

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
buildDuration	10.5s	10.6s	⚠️ +77ms
buildDurationCached	4.1s	4.1s	-33ms
nodeModulesSize	50.3 MB	50.3 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.31	2.326	⚠️ +0.02
/ avg req/sec	1082.17	1074.61	⚠️ -7.56
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.244	1.262	⚠️ +0.02
/error-in-render avg req/sec	2010.36	1980.91	⚠️ -29.45

Client Bundles (main, webpack, commons)

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
17.HASH.js gzip	185 B	185 B	✓
677f882d2ed8..HASH.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	10.6 kB	10.6 kB	✓
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	67.7 kB	67.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
_app-HASH.js gzip	965 B	965 B	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.71 kB	2.71 kB	✓
head-HASH.js gzip	2.97 kB	2.97 kB	✓
hooks-HASH.js gzip	911 B	911 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	2.94 kB	2.94 kB	✓
withRouter-HASH.js gzip	294 B	294 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	17.7 kB	17.7 kB	✓

Client Build Manifests

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
_buildManifest.js gzip	499 B	499 B	✓
Overall change	499 B	499 B	✓

Rendered Page Sizes

	vercel/next.js canary	stefanprobst/next.js fix/eslint-config-next-web-vitals	Change
index.html gzip	577 B	577 B	✓
link.html gzip	590 B	590 B	✓
withRouter.html gzip	569 B	569 B	✓
Overall change	1.74 kB	1.74 kB	✓

Commit: f43ab22

[ijjk]

Fix and added test looks good, thanks!