Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update has query encoding when used in path #27762

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 4, 2021

This is a follow-up to #26963 which after discussion changes to interpolate the decoded variant of the value into the path.

x-ref: #24775

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Aug 4, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review August 4, 2021 15:56
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Aug 4, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
buildDuration 15.1s 15.3s ⚠️ +213ms
buildDurationCached 3.5s 3.4s -78ms
nodeModulesSize 50.1 MB 50.1 MB -1.36 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
/ failed reqs 0 0
/ total time (seconds) 2.608 2.646 ⚠️ +0.04
/ avg req/sec 958.5 944.82 ⚠️ -13.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.447 1.427 -0.02
/error-in-render avg req/sec 1727.2 1752.52 +25.32
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.12 kB 4.12 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
_buildManifest.js gzip 490 B 490 B
Overall change 490 B 490 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
index.html gzip 531 B 531 B
link.html gzip 542 B 542 B
withRouter.html gzip 523 B 523 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
buildDuration 12.4s 12.1s -319ms
buildDurationCached 4.8s 4.7s -158ms
nodeModulesSize 50.1 MB 50.1 MB -1.36 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
/ failed reqs 0 0
/ total time (seconds) 2.637 2.624 -0.01
/ avg req/sec 947.96 952.6 +4.64
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.48 1.497 ⚠️ +0.02
/error-in-render avg req/sec 1688.78 1669.86 ⚠️ -18.92
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.5 kB 10.5 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.94 kB 2.94 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
_buildManifest.js gzip 499 B 499 B
Overall change 499 B 499 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/has-query-encoding Change
index.html gzip 577 B 577 B
link.html gzip 589 B 589 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: f770910

@kodiakhq kodiakhq bot merged commit bce06f5 into vercel:canary Aug 4, 2021
@ijjk ijjk deleted the update/has-query-encoding branch August 4, 2021 20:47
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
This is a follow-up to vercel#26963 which after discussion changes to interpolate the decoded variant of the value into the path. 

x-ref: vercel#24775

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants