Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust AVIF size so that its smaller than WebP size #31494

Merged
merged 12 commits into from
Nov 17, 2021
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Nov 16, 2021

Generally, AVIF quality can be lower compared to WebP so we can adjust this for the user so that it looks roughly the same depending on if the browser supports AVIF or WebP.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Nov 16, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@styfle styfle requested a review from atcastle November 17, 2021 18:26
@styfle styfle marked this pull request as ready for review November 17, 2021 18:27
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

ijjk
ijjk previously approved these changes Nov 17, 2021
@styfle styfle changed the title AVIF vs WebP size Adjust AVIF size so that its smaller than WebP size Nov 17, 2021
@styfle styfle requested a review from ijjk November 17, 2021 19:50
@ijjk
Copy link
Member

ijjk commented Nov 17, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js avif-quality-size Change
buildDuration 17.7s 17.7s -60ms
buildDurationCached 3.5s 3.6s ⚠️ +54ms
nodeModulesSize 338 MB 338 MB ⚠️ +401 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js avif-quality-size Change
/ failed reqs 0 0
/ total time (seconds) 2.992 2.973 -0.02
/ avg req/sec 835.52 840.99 +5.47
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.354 1.334 -0.02
/error-in-render avg req/sec 1845.81 1874.57 +28.76
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js avif-quality-size Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js avif-quality-size Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js avif-quality-size Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js avif-quality-size Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js avif-quality-size Change
index.html gzip 524 B 524 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js avif-quality-size Change
buildDuration 19.4s 19.2s -210ms
buildDurationCached 3.6s 3.5s -63ms
nodeModulesSize 338 MB 338 MB ⚠️ +401 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js avif-quality-size Change
/ failed reqs 0 0
/ total time (seconds) 2.929 2.915 -0.01
/ avg req/sec 853.42 857.49 +4.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.379 1.398 ⚠️ +0.02
/error-in-render avg req/sec 1812.43 1787.66 ⚠️ -24.77
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js avif-quality-size Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js avif-quality-size Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js avif-quality-size Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary vercel/next.js avif-quality-size Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js avif-quality-size Change
index.html gzip 524 B 524 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB
Commit: 85f9fcc

@kodiakhq kodiakhq bot merged commit 44b4dbc into canary Nov 17, 2021
@kodiakhq kodiakhq bot deleted the avif-quality-size branch November 17, 2021 20:31
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New avif image larger than webp
2 participants