Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : example/with-noscript to use next@latest and react-dom #3237

Merged
merged 2 commits into from
Nov 4, 2017
Merged

fix : example/with-noscript to use next@latest and react-dom #3237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e16a66
example with-noscript use next@latest
andykenward Nov 3, 2017
9db361b
fix : example/with-noscript react-dom/server usage
andykenward Nov 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/with-noscript/components/Noscript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react'
import ReactDOMServer from 'react-dom/lib/ReactDOMServer'
import ReactDOMServer from 'react-dom/server'

export default function Noscript (props) {
const staticMarkup = ReactDOMServer.renderToStaticMarkup(props.children)
Expand Down
2 changes: 1 addition & 1 deletion examples/with-noscript/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module.exports = {
webpack: (config, { dev }) => {
if (!dev) {
config.resolve.alias = {
'react-dom/server': require.resolve('react-dom/dist/react-dom-server.min.js')
'react-dom/server': require.resolve('react-dom/umd/react-dom-server.browser.production.min.js')
}
}
return config
Expand Down
2 changes: 1 addition & 1 deletion examples/with-noscript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"start": "next start"
},
"dependencies": {
"next": "^3.0.3",
"next": "latest",
"react": "^16.0.0",
"react-dom": "^16.0.0",
"react-lazyload": "^2.2.7"
Expand Down