Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure fetch polyfill is loaded in next-server #33616

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 24, 2022

In #33395 we removed the fetch polyfill from base-server but it still needs to be loaded in next-server so this ensures it's added there and this also fixes the case where the shared worker pool is disabled so the fetch polyfill isn't loaded in build/utils. This also adds test cases to the isolated suite that leverage fetch in current failing ways.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 24, 2022
@ijjk ijjk marked this pull request as ready for review January 24, 2022 21:02
@ijjk
Copy link
Member Author

ijjk commented Jan 24, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
buildDuration 12.2s 12.4s ⚠️ +218ms
buildDurationCached 3.1s 3.1s -1ms
nodeModulesSize 355 MB 355 MB ⚠️ +151 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
/ failed reqs 0 0
/ total time (seconds) 2.96 2.943 -0.02
/ avg req/sec 844.58 849.47 +4.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.363 1.346 -0.02
/error-in-render avg req/sec 1833.6 1857.43 +23.83
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.87 kB 4.87 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.2 kB 14.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
index.html gzip 530 B 530 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
buildDuration 15.9s 15.7s -131ms
buildDurationCached 3.2s 3.1s -38ms
nodeModulesSize 355 MB 355 MB ⚠️ +151 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
/ failed reqs 0 0
/ total time (seconds) 2.912 2.949 ⚠️ +0.04
/ avg req/sec 858.45 847.74 ⚠️ -10.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.351 1.405 ⚠️ +0.05
/error-in-render avg req/sec 1850.37 1779.41 ⚠️ -70.96
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.89 kB 4.89 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.2 kB 14.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/fetch-next-server Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB
Commit: 5d0727a

@ijjk ijjk requested a review from styfle January 24, 2022 21:21
@ijjk ijjk merged commit e8c15e5 into vercel:canary Jan 24, 2022
@ijjk ijjk deleted the fix/fetch-next-server branch January 24, 2022 21:38
@huozhi
Copy link
Member

huozhi commented Jan 24, 2022

this also fixes the case where the shared worker pool is disabled

Nice catch! Thanks! 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants