Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libc fields to Linux platform packages #35354

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Add libc fields to Linux platform packages #35354

merged 1 commit into from
Mar 16, 2022

Conversation

Brooooooklyn
Copy link
Contributor

Related: yarnpkg/berry#3981

With yarn 3.2 +, developers will install one less package on the Linux platform

@ijjk
Copy link
Member

ijjk commented Mar 16, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js libc-fields Change
buildDuration 16.3s 16.3s ⚠️ +2ms
buildDurationCached 6.3s 6.2s -82ms
nodeModulesSize 456 MB 456 MB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js libc-fields Change
/ failed reqs 0 0
/ total time (seconds) 3.25 3.225 -0.02
/ avg req/sec 769.32 775.26 +5.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.443 1.414 -0.03
/error-in-render avg req/sec 1732.54 1768.52 +35.98
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js libc-fields Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js libc-fields Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js libc-fields Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary vercel/next.js libc-fields Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js libc-fields Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js libc-fields Change
buildDuration 20s 19.8s -178ms
buildDurationCached 6.2s 6.2s ⚠️ +39ms
nodeModulesSize 456 MB 456 MB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js libc-fields Change
/ failed reqs 0 0
/ total time (seconds) 3.25 3.248 0
/ avg req/sec 769.12 769.75 +0.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.447 1.413 -0.03
/error-in-render avg req/sec 1727.37 1768.71 +41.34
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js libc-fields Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js libc-fields Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js libc-fields Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js libc-fields Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js libc-fields Change
index.html gzip 530 B 530 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 600d01a

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle merged commit 98d7ee3 into canary Mar 16, 2022
@styfle styfle deleted the libc-fields branch March 16, 2022 13:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants