Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Remove babel from with-mobx-react-lite example #40302

Closed
wants to merge 2 commits into from
Closed

[Docs] Remove babel from with-mobx-react-lite example #40302

wants to merge 2 commits into from

Conversation

HaNdTriX
Copy link
Contributor

@HaNdTriX HaNdTriX commented Sep 7, 2022

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue was opened via the examples template. label Sep 7, 2022
@HaNdTriX HaNdTriX mentioned this pull request Sep 7, 2022
Closed
2 tasks
@balazsorban44
Copy link
Member

balazsorban44 commented Sep 7, 2022 •
edited
Loading

I think we should merge:

  • with-mobx-react-lite
  • with-mobx-state-tree-typescript
  • with-mobx-state-tree
  • with-mobx

To a single with-mobx example by removing code from the others and point to the with-mobx directory through a README.md. What do you think?

@HaNdTriX
Copy link
Contributor Author

HaNdTriX commented Sep 7, 2022

From my point of view this makes totally sense. All these legacy examples are kind of confusing.

@HaNdTriX HaNdTriX closed this Sep 7, 2022
@HaNdTriX HaNdTriX deleted the examples/mobx-lite branch September 7, 2022 11:16
@HaNdTriX
Copy link
Contributor Author

HaNdTriX commented Sep 7, 2022

@balazsorban44 it might make sense to consolidate:

with-mobx-react-lite -> with-mobx
with-mobx-state-tree-typescript -> with-mobx-state-tree

since mobx-state-tree is a different lib.

In the end both examples with-mobx & with-mobx-state-tree should be up to date and written in typescript.

This was referenced Sep 7, 2022
Merged
Merged
kodiakhq bot pushed a commit that referenced this pull request Sep 8, 2022
@HaNdTriX
[Docs] Merge with-mobx-state-tree with with-mobx-state-tree-typescrip…
2b9268a 
…t example (#40306)

## Changes

see commits

## Context

As discussed in #40302 (comment) we are going to merge the mobx examples.

#40302

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
kodiakhq bot pushed a commit that referenced this pull request Sep 14, 2022
@HaNdTriX
[Docs] Remove legacy mobx example (#40304)
155a4d5 
## Info

This PR merges with-mobx-lite into with-mobx. After that we will migrate `with-mobx` to typescript.

## Context

As discussed in #40302 (comment) we are going to merge the mobx examples.

#40302

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaNdTriX @balazsorban44 @ijjk