Refactor build context for better plugin state sharing #46706
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love the change made in #46666! This PR tries to refactor it by adding an abstraction
pluginState
object. For the build process, it's just a serializable field that we can attach to the result and resume it as the state at the process beginning. For Webpack plugins, it's an object with all the needed states and their initial values.The proxy is for lazily initializing these states so they're still global variables, but always initialized after the worker resumes the plugin state.
This way we no longer need to import these plugins from the build worker, and mutate each module export field:
Object.assign((flightPluginModule as any)[field], (serializedFlightMaps as any)[field])
.Closes NEXT-758.
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
pnpm build && pnpm lint