Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure chained middleware rewrites work properly #46866

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Ensure chained middleware rewrites work properly #46866

merged 1 commit into from
Mar 7, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 7, 2023

Follow-up to #45772 this ensures the rewrite header can be correctly set when a chained middleware rewrite is occurring.

x-ref: slack thread

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

@ijjk ijjk marked this pull request as ready for review March 7, 2023 07:09
@ijjk ijjk merged commit e0e627c into vercel:canary Mar 7, 2023
@ijjk ijjk deleted the fix/middleware-nested-rewrite branch March 7, 2023 07:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ijjk