Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update router.md #47210

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Update router.md #47210

merged 2 commits into from
Mar 17, 2023

Conversation

FSaldanha
Copy link
Contributor

Not including router as dependency of useEffect hooks will trigger the exhaustive-deps ESLint rule. The official example includes it correctly.

Not including `router` as dependency of `useEffect` hooks will trigger the `exhaustive-deps` ESLint rule. The [official example](https://github.com/vercel/next.js/blob/canary/examples/with-loading/pages/_app.tsx#L30) includes it correctly.
@jankaifer jankaifer enabled auto-merge (squash) March 17, 2023 09:33
Copy link
Contributor

@jankaifer jankaifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and opening PR for it.

@jankaifer jankaifer merged commit e49bfea into vercel:canary Mar 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants