Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update query param prefix to reduce length #48051

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 7, 2023

With the addition of the query prefix we can hit the max length for PCRE named matches so this reduces the prefix length and ensures we go through the param name validation still

x-ref: https://twitter.com/simonecervini/status/1644123851003928579

@ijjk
Copy link
Member Author

ijjk commented Apr 7, 2023

Failing test suites

Commit: 9b4d9e5

pnpm testheadless test/e2e/app-dir/navigation/navigation.test.ts

  • app dir - navigation > redirect > components > should redirect to external url
Expand output

● app dir - navigation › redirect › components › should redirect to external url

thrown: "Exceeded timeout of 240000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  157 |         })
  158 |
> 159 |         it('should redirect to external url', async () => {
      |         ^
  160 |           const browser = await next.browser('/redirect/external')
  161 |           expect(await browser.waitForElementByCss('h1').text()).toBe(
  162 |             'Example Domain'

  at e2e/app-dir/navigation/navigation.test.ts:159:9
  at e2e/app-dir/navigation/navigation.test.ts:130:7
  at fn (e2e/app-dir/navigation/navigation.test.ts:129:5)
  at lib/e2e-utils.ts:242:5

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk merged commit 40687da into vercel:canary Apr 7, 2023
@ijjk ijjk deleted the fix/param-prefix branch April 7, 2023 00:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant