Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing babel configuration in sw-precache example #4856

Merged
merged 7 commits into from
Jul 27, 2018
Merged

Missing babel configuration in sw-precache example #4856

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0fa8667
Added @babel/preset-stage-0
jmaguirrei Jul 27, 2018
b8d6a33
Create .babelrc
jmaguirrei Jul 27, 2018
3da9bb7
Merge branch 'canary' into canary
jmaguirrei Jul 27, 2018
5101a18
Merge branch 'canary' into canary
jmaguirrei Jul 27, 2018
8e9aef2
Update .babelrc
jmaguirrei Jul 27, 2018
b1bf94f
Update .babelrc
jmaguirrei Jul 27, 2018
fbbd024
Update package.json
jmaguirrei Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions examples/with-sw-precache/.babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no "test" script in this example so the babelrc shouldn't be here right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right, I corrected it.

"presets": [
[ "next/babel" ]
]
}