update storybook example (copy from vercel/vercel) #50865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethan-Arrowood
requested review from
timneutkens,
ijjk,
shuding,
a team,
leerob and
steven-tey
as code owners
|
Whoops I think i started from main. Forgot y'all use canary. Let me fix |
ijjk
reviewed
Jun 6, 2023
|
Which should be source? I like that you can use this with |
Ethan-Arrowood
force-pushed
the
example/update-storybook
branch
from
fb79250 to
49cd139
Compare
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
This one being source of truth sounds good to me |
ijjk
previously approved these changes
Jun 14, 2023
ijjk
approved these changes
Jun 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
with-storybookexample to be the example located invercel/vercel.The motivation for this change is that we now have better support for storybook. It is now treated as its own framework and so users can specify the
storybookframework as well as custom build commandbuild-storybookin order to get near zero-config support 🌟