Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next-flight-css-loader - fix !=! support #51115

Merged
merged 4 commits into from
Jul 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 40 additions & 5 deletions packages/next/src/build/webpack/config/blocks/css/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,14 @@ export const css = curry(async function css(
test: regexCssModules,
issuerLayer: APP_LAYER_RULE,
use: [
require.resolve('../../../loaders/next-flight-css-loader'),
{
loader: require.resolve(
'../../../loaders/next-flight-css-loader'
),
options: {
cssModules: true,
},
},
...getCssModuleLoader(
{ ...ctx, isAppDir: true },
lazyPostCSSInitializer
Expand Down Expand Up @@ -291,7 +298,14 @@ export const css = curry(async function css(
test: regexSassModules,
issuerLayer: APP_LAYER_RULE,
use: [
require.resolve('../../../loaders/next-flight-css-loader'),
{
loader: require.resolve(
'../../../loaders/next-flight-css-loader'
),
options: {
cssModules: true,
},
},
...getCssModuleLoader(
{ ...ctx, isAppDir: true },
lazyPostCSSInitializer,
Expand Down Expand Up @@ -338,7 +352,14 @@ export const css = curry(async function css(
sideEffects: true,
test: [regexCssGlobal, regexSassGlobal],
issuerLayer: APP_LAYER_RULE,
use: require.resolve('../../../loaders/next-flight-css-loader'),
use: {
loader: require.resolve(
'../../../loaders/next-flight-css-loader'
),
options: {
cssModules: false,
},
},
})
: null,
markRemovable({
Expand Down Expand Up @@ -389,7 +410,14 @@ export const css = curry(async function css(
test: regexCssGlobal,
issuerLayer: APP_LAYER_RULE,
use: [
require.resolve('../../../loaders/next-flight-css-loader'),
{
loader: require.resolve(
'../../../loaders/next-flight-css-loader'
),
options: {
cssModules: false,
},
},
...getGlobalCssLoader(
{ ...ctx, isAppDir: true },
lazyPostCSSInitializer
Expand All @@ -401,7 +429,14 @@ export const css = curry(async function css(
test: regexSassGlobal,
issuerLayer: APP_LAYER_RULE,
use: [
require.resolve('../../../loaders/next-flight-css-loader'),
{
loader: require.resolve(
'../../../loaders/next-flight-css-loader'
),
options: {
cssModules: false,
},
},
...getGlobalCssLoader(
{ ...ctx, isAppDir: true },
lazyPostCSSInitializer,
Expand Down
74 changes: 39 additions & 35 deletions packages/next/src/build/webpack/loaders/next-flight-css-loader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,52 +5,56 @@
*/

import crypto from 'crypto'
import type webpack from 'webpack'

export function pitch(this: any) {
if (process.env.NODE_ENV !== 'production') {
const content = this.fs.readFileSync(this.resourcePath)
this.data.__checksum = crypto
.createHash('sha256')
.update(typeof content === 'string' ? Buffer.from(content) : content)
.digest()
.toString('hex')
}
type NextServerCSSLoaderOptions = {
cssModules: boolean
}

const NextServerCSSLoader = function (this: any, content: string) {
this.cacheable && this.cacheable()

// Only add the checksum during development.
if (process.env.NODE_ENV !== 'production') {
const isCSSModule = this.resourcePath.match(/\.module\.(css|sass|scss)$/)
const checksum = crypto
.createHash('sha256')
.update(
this.data.__checksum +
(typeof content === 'string' ? Buffer.from(content) : content)
)
.digest()
.toString('hex')
.substring(0, 12)

if (isCSSModule) {
return `\
const NextServerCSSLoader: webpack.LoaderDefinitionFunction<NextServerCSSLoaderOptions> =
function (content) {
this.cacheable && this.cacheable()
const options = this.getOptions()
let isCSSModule = options.cssModules

// Only add the checksum during development.
if (process.env.NODE_ENV !== 'production') {
// This check is only for backwards compatibility.
// TODO: Remove this in the next major version (next 14)
if (isCSSModule === undefined) {
this.emitWarning(
new Error(
"No 'cssModules' option was found for the next-flight-css-loader plugin."
)
)
isCSSModule =
this.resourcePath.match(/\.module\.(css|sass|scss)$/) !== null
}
const checksum = crypto
.createHash('sha256')
.update(typeof content === 'string' ? Buffer.from(content) : content)
.digest()
.toString('hex')
.substring(0, 12)

if (isCSSModule) {
return `\
${content}
module.exports.__checksum = ${JSON.stringify(checksum)}
`
}
}

// Server CSS imports are always available for HMR, so we attach
// `module.hot.accept()` to the generated module.
const hmrCode = 'if (module.hot) { module.hot.accept() }'
// Server CSS imports are always available for HMR, so we attach
// `module.hot.accept()` to the generated module.
const hmrCode = 'if (module.hot) { module.hot.accept() }'

return `\
return `\
export default ${JSON.stringify(checksum)}
${hmrCode}
`
}
}

return content
}
return content
}

export default NextServerCSSLoader