added good to know in /app based pages and layout in nested layouts
#51558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mentions that inner layouts should not contain html or body tags
leerob
reviewed
Jun 20, 2023
docs/02-app/01-building-your-application/01-routing/02-pages-and-layouts.mdx
Outdated
Show resolved
Hide resolved
|
Notifying the following users due to files changed in this PR: @timneutkens, @ijjk, @shuding, @huozhi, @feedthejim: This comment was posted based on the notify modifier. |
…nd-layouts.mdx Co-authored-by: Lee Robinson <me@leerob.io>
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
2 similar comments
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
leerob
reviewed
Jun 21, 2023
docs/02-app/01-building-your-application/01-routing/02-pages-and-layouts.mdx
Outdated
Show resolved
Hide resolved
leerob
approved these changes
Jun 21, 2023
ijjk
approved these changes
Jun 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a good to know section mentioning that one should not add
htmlorbodytags in nested layouts under/appbased routing.It was not mentioned anywhere before and often one forgets this while migrating from the
/pagesbased routingFixes #51556