Avoiding try-catch block on examples/app-dir-i18n-routing #51786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Negotiator.languages()` accepts an array of available locales and returns only results that are present in it. This effectively eliminates the need to use a try-catch block when calling `matchLocale`.
milovangudelj
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
feedthejim
as code owners
milovangudelj
changed the title
ijjk
previously approved these changes
Jun 26, 2023
|
Do I have to keep updating the branch until it gets approved and merged or is that up to whoever is reviewing/approving it? |
ijjk
approved these changes
Jun 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negotiator.languages()accepts an array of available locales and returns only results that are present in it.This effectively eliminates the need to use a try-catch block when calling
matchLocale.