docs(examples): fix next-translate prod hydration error in layout #52653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aralroca
changed the title
leerob
reviewed
Dec 25, 2023
leerob
approved these changes
Aug 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with aralroca/next-translate#1094
In development there aren't any error, but doing
yarn build && yarn startwas an hydration error. After check client and server HTML I realize that the server doesn't has the<html>,<head>tags, but the client HTML does. To fix it, I updated the layout, after this now is working fine.It is likely that parallel to this error it would be good to notify during the development of this error if there is no
<html>in the root layout. What do you think? I can look into making another PR to warn about this.