Add package.json engine requirement for Node <20, to help contributors use compatible Node version #52955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s use compatible Node version
domdomegg
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
feedthejim
as code owners
jakebailey
reviewed
Jul 21, 2023
| @@ -243,7 +243,7 @@ | |||
| "@types/react-dom": "18.2.4" | |||
| }, | |||
| "engines": { | |||
| "node": ">=16.8.0" | |||
| "node": ">=16.8.0 <20" | |||
| }, | |||
| "packageManager": "pnpm@7.24.3" | |||
There was a problem hiding this comment.
You could just bump this to the latest v7 version, and you wouldn't need to restrict the node version to <20; this issue was fixed in 7.32.2+ and 8.3.1+.
There was a problem hiding this comment.
Oops, you said there were issues and I ignored that, my mistake.
There was a problem hiding this comment.
That being said, there have been fixes since 7.32.2 so, maybe it works?
There was a problem hiding this comment.
Agreed bumping PNPM may work - but while it's unclear whether this will break things (awaiting confirmation on what broke last time, given CI didn't catch it), I think this will be useful as an interim measure.
Malena205
approved these changes
Jul 23, 2023
|
Superceded by #50923 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #52943
There's a PNPM bug that stops PNPM 7.24.3 working on Node 20: pnpm/pnpm#6424. We previously tried updating PNPM to fix this (#51406), but this was reverted due to issues (#51539).
While we wait on a longer term solution (discussing in #52943), this temporary solution will help new contributors figure out what's going wrong sooner. The current experience is to get a few warnings and then get stuck: this will change the behaviour so it clearly asks people to use a different Node version.