Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): fix broken link #53021

Merged
merged 2 commits into from
Jul 21, 2023
Merged

chore(docs): fix broken link #53021

merged 2 commits into from
Jul 21, 2023

Conversation

styfle
Copy link
Member

@styfle styfle commented Jul 21, 2023 •
edited
Loading

This link is failing CI as seen here:

https://github.com/vercel/next.js/actions/runs/5623454975/job/15238167610

Error: The action could not create a Github comment because it is initiated from a forked repo. View the action logs for a list of broken links.
This PR introduces broken links to the docs:
┌─────────┬───────────────────────────────────────────────────────────────────────────────┬──────┬─────────────────────────────────────────────────────────────────────────────────────┐
│ (index) │                                     link                                      │ type │                                       docPath                                       │
├─────────┼───────────────────────────────────────────────────────────────────────────────┼──────┼─────────────────────────────────────────────────────────────────────────────────────┤
│    0    │ 'app/building-your-application/configuring/typescript#statically-typed-links' │      │ 'docs/02-app/01-building-your-application/01-routing/03-linking-and-navigating.mdx' │
└─────────┴───────────────────────────────────────────────────────────────────────────────┴──────┴─────────────────────────────────────────────────────────────────────────────────────┘
Error: This PR introduces broken links to the docs. The action could not create a Github check because it is initiated from a forked repo.
Error: Process completed with exit code 1.

@styfle styfle marked this pull request as ready for review July 21, 2023 18:05
@styfle styfle requested review from a team as code owners July 21, 2023 18:05
@styfle styfle requested review from manovotny and lydiahallie July 21, 2023 18:05
@styfle styfle mentioned this pull request Jul 21, 2023
Merged
@kodiakhq kodiakhq bot merged commit 26a57af into canary Jul 21, 2023
@kodiakhq kodiakhq bot deleted the styfle/fix-failing-ci-verify-links branch July 21, 2023 18:28
kodiakhq bot pushed a commit that referenced this pull request Jul 22, 2023
@styfle
chore(ci): always run validate-docs-links action (#53022)
bc9d69d 
We should unconditionally run this action so we can mark it as "required".

It only takes about 13 seconds for each PR so it shouldn't put too much additional load on our CI infra.

<img width="811" alt="image" src="https://github.com/vercel/next.js/assets/229881/5c8596e1-71be-4f09-ac29-e0c4a9f12253">

- Depends on the fix from #53021
This was referenced Aug 11, 2023
Open
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delbaoliveira delbaoliveira delbaoliveira approved these changes

@ztanner ztanner ztanner approved these changes

@manovotny manovotny Awaiting requested review from manovotny manovotny was automatically assigned from vercel/devex

@lydiahallie lydiahallie Awaiting requested review from lydiahallie lydiahallie was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@styfle @ztanner @delbaoliveira @ijjk