Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size property to ReadonlySearchParams #53144

Merged
merged 19 commits into from
Aug 17, 2023
Merged

Add size property to ReadonlySearchParams #53144

Changes from 4 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6ffa617
Add property to ReadonlySearchParams
bencmbrook Jul 25, 2023
d87f9eb
revert some test code
bencmbrook Jul 25, 2023
75348d6
Update navigation.ts
bencmbrook Jul 25, 2023
8449948
Switch to property reference
bencmbrook Jul 25, 2023
5bc9a09
Add test for constructing ReadonlyURLSearchParams from URLSearchParams
bencmbrook Jul 27, 2023
7a695ca
revert a change to .vscode/settings.json from prev commit
bencmbrook Jul 27, 2023
4b7f181
revert lockfile change
bencmbrook Jul 27, 2023
e934595
Merge branch 'canary' into canary
styfle Jul 27, 2023
a287d63
update to test for URLSearchParams from ReadonlyURLSearchParams
bencmbrook Jul 28, 2023
91ef4fe
Merge branch 'canary' into canary
bencmbrook Jul 28, 2023
94317fc
Update packages/next/src/client/components/navigation.ts
bencmbrook Aug 16, 2023
277a2f6
Merge branch 'canary' into canary
bencmbrook Aug 16, 2023
6218182
Merge branch 'canary' into canary
timneutkens Aug 16, 2023
28317cc
prettier fix
bencmbrook Aug 16, 2023
1dfc62b
Merge branch 'canary' into canary
bencmbrook Aug 17, 2023
9ba9a51
Merge branch 'canary' into canary
styfle Aug 17, 2023
7b6a3aa
Merge branch 'canary' into canary
bencmbrook Aug 17, 2023
1efd60e
Merge branch 'canary' into canary
bencmbrook Aug 17, 2023
e60590c
Merge branch 'canary' into canary
ztanner Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/next/src/client/components/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export class ReadonlyURLSearchParams {
keys: URLSearchParams['keys']
values: URLSearchParams['values']
toString: URLSearchParams['toString']
size: URLSearchParams['size']
bencmbrook marked this conversation as resolved.
Show resolved Hide resolved

constructor(urlSearchParams: URLSearchParams) {
this[INTERNAL_URLSEARCHPARAMS_INSTANCE] = urlSearchParams
Expand All @@ -45,6 +46,7 @@ export class ReadonlyURLSearchParams {
this.keys = urlSearchParams.keys.bind(urlSearchParams)
this.values = urlSearchParams.values.bind(urlSearchParams)
this.toString = urlSearchParams.toString.bind(urlSearchParams)
this.size = urlSearchParams.size;
}
[Symbol.iterator]() {
return this[INTERNAL_URLSEARCHPARAMS_INSTANCE][Symbol.iterator]()
Expand Down