Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXAMPLE: fix with-supabase signup button style #53531

Merged
merged 6 commits into from
Aug 4, 2023
Merged

EXAMPLE: fix with-supabase signup button style #53531

merged 6 commits into from
Aug 4, 2023

Conversation

gon250
Copy link
Contributor

@gon250 gon250 commented Aug 3, 2023

What?

Fix example with-supabase https://github.com/vercel/next.js/tree/canary/examples/with-supabase signup button

Why?

Signup button text color is not the right one so the developer is not able to see the text.

How?

Updated the style using tailwind as it is what we are using in the example.

Before:
image

After (Fixed):
image

@gon250 gon250 requested review from a team as code owners August 3, 2023 15:12
@ijjk ijjk added the examples Issue was opened via the examples template. label Aug 3, 2023
balazsorban44
balazsorban44 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Aug 4, 2023 •
edited by styfle
Loading

Allow CI Workflow Run

  • approve CI run for commit: b80db0a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@styfle styfle added the CI approved Approve running CI for fork label Aug 4, 2023
@kodiakhq kodiakhq bot merged commit a66aca1 into vercel:canary Aug 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@styfle styfle styfle approved these changes

@timeyoutakeit timeyoutakeit Awaiting requested review from timeyoutakeit timeyoutakeit was automatically assigned from vercel/devex

@lydiahallie lydiahallie Awaiting requested review from lydiahallie lydiahallie was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
CI approved Approve running CI for fork examples Issue was opened via the examples template. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gon250 @ijjk @styfle @balazsorban44