Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runner labels #53925

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Update runner labels #53925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f64a9d4
Update runner labels
ijjk Aug 11, 2023
8c94696
Merge branch 'canary' into ci/update-labels
ijjk Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ env:
TURBO_VERSION: 1.10.9
NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18.16.1
TEST_CONCURRENCY: 6
TEST_CONCURRENCY: 8
# disable backtrace for test snapshots
RUST_BACKTRACE: 0

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build_reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ env:
TURBO_VERSION: 1.10.9
NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18.16.1
TEST_CONCURRENCY: 6
TEST_CONCURRENCY: 8
# disable backtrace for test snapshots
RUST_BACKTRACE: 0

Expand All @@ -78,7 +78,7 @@ jobs:
- 'self-hosted'
- 'linux'
- 'x64'
- 'hosted-ci-cd:ignore'
- 'metal'

steps:
- run: fnm install ${{ inputs.nodeVersion || env.NODE_LTS_VERSION }}
Expand Down
1 change: 0 additions & 1 deletion test/integration/next-image-legacy/trailing-slash/test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ describe('Image Component Trailing Slash Tests', () => {
afterAll(() => killApp(app))

it('should include trailing slash when trailingSlash is set on config file during next start', async () => {
expect.assertions(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this was removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's using check() so expect() can be called more than once which causes this flake when check() actually retries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should move the expect outside of the check() and outside of the try/catch so that its called exactly once.

let browser
try {
browser = await webdriver(appPort, '/')
Expand Down
1 change: 0 additions & 1 deletion test/integration/next-image-new/trailing-slash/test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ describe('Image Component Trailing Slash Tests', () => {
afterAll(() => killApp(app))

it('should include trailing slash when trailingSlash is set on config file during next start', async () => {
expect.assertions(1)
let browser
try {
browser = await webdriver(appPort, '/')
Expand Down