Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update turbo env handling #53970

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Update turbo env handling #53970

merged 5 commits into from
Aug 14, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 14, 2023

This ensures env variables are passed through as expected when building the next-swc binaries, also removes an extra GH actions that isn't really needed as it's just a wrapper around docker run.

Validated changes against run here https://github.com/vercel/next.js/actions/runs/5851719808/job/15862899331

@ijjk ijjk requested review from a team as code owners August 14, 2023 04:30
@ijjk ijjk requested review from S3Prototype and Nutlope August 14, 2023 04:30
@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Aug 14, 2023
@ijjk ijjk merged commit 6b6f0a2 into canary Aug 14, 2023
@ijjk ijjk deleted the ci/update-turbo-env branch August 14, 2023 04:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant