Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tsconfig extending for @next/thrid-parties package #53991

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Aug 14, 2023

x-ref: https://github.com/vercel/next.js/actions/runs/5854800073/job/15871731468

Do not use the packages/next tsconfig, aligning tsconfig with other @next/ packages. So it won't run tsc with tsec plugin

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Aug 14, 2023
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely needs the build to run? 🤔

@ijjk
Copy link
Member

ijjk commented Aug 14, 2023

Failing test suites

Commit: d3d2bfe

pnpm testheadless test/e2e/app-dir/third-parties/basic.test.ts

  • @next/third-parties basic usage > renders YoutubeEmbed
  • @next/third-parties basic usage > renders GoogleMapsEmbed
Expand output

● @next/third-parties basic usage › renders YoutubeEmbed

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 0

  15 |       const baseContainer = $('[data-ntpc="YoutubeEmbed"]')
  16 |       const youtubeContainer = $('lite-youtube')
> 17 |       expect(baseContainer.length).toBe(1)
     |                                    ^
  18 |       expect(youtubeContainer.length).toBe(1)
  19 |     })
  20 |

  at Object.<anonymous> (e2e/app-dir/third-parties/basic.test.ts:17:36)

● @next/third-parties basic usage › renders GoogleMapsEmbed

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 0

  26 |         '[src="https://www.google.com/maps/embed/v1/place?key=XYZ&q=Brooklyn+Bridge,New+York,NY"]'
  27 |       )
> 28 |       expect(baseContainer.length).toBe(1)
     |                                    ^
  29 |       expect(mapContainer.length).toBe(1)
  30 |     })
  31 |   }

  at Object.<anonymous> (e2e/app-dir/third-parties/basic.test.ts:28:36)

Read more about building and testing Next.js in contributing.md.

pnpm testheadless test/e2e/third-parties/index.test.ts

  • @next/third-parties basic usage > renders YoutubeEmbed
  • @next/third-parties basic usage > renders GoogleMapsEmbed
Expand output

● @next/third-parties basic usage › renders YoutubeEmbed

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 0

  15 |       const baseContainer = $('[data-ntpc="YoutubeEmbed"]')
  16 |       const youtubeContainer = $('lite-youtube')
> 17 |       expect(baseContainer.length).toBe(1)
     |                                    ^
  18 |       expect(youtubeContainer.length).toBe(1)
  19 |     })
  20 |

  at Object.<anonymous> (e2e/third-parties/index.test.ts:17:36)

● @next/third-parties basic usage › renders GoogleMapsEmbed

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 0

  26 |         '[src="https://www.google.com/maps/embed/v1/place?key=XYZ&q=Brooklyn+Bridge,New+York,NY"]'
  27 |       )
> 28 |       expect(baseContainer.length).toBe(1)
     |                                    ^
  29 |       expect(mapContainer.length).toBe(1)
  30 |     })
  31 |   }

  at Object.<anonymous> (e2e/third-parties/index.test.ts:28:36)

Read more about building and testing Next.js in contributing.md.

@huozhi huozhi changed the title Exclude include thrid-party build script from pipeline Remove tsconfig extending for @next/thrid-parties package Aug 14, 2023
@huozhi huozhi requested a review from timneutkens August 14, 2023 11:23
@timneutkens timneutkens merged commit 4c84ea5 into canary Aug 14, 2023
@timneutkens timneutkens deleted the fix/thrid-party-build-script branch August 14, 2023 12:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants