Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 10-testing.mdx #54107

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Update 10-testing.mdx #54107

merged 2 commits into from
Aug 24, 2023

Conversation

uzairali001
Copy link
Contributor

@uzairali001 uzairali001 commented Aug 16, 2023

Fixed next/jest.js import in documentation. without .js it show this error

Error [ERR_MODULE_NOT_FOUND]: Cannot find module 'F:\React\my-project\node_modules\next\jest' imported from F:\React\my-project\jest.config.mjs
Did you mean to import next/jest.js?
    at new NodeError (node:internal/errors:399:5)
    at finalizeResolution (node:internal/modules/esm/resolve:326:11)
    at moduleResolve (node:internal/modules/esm/resolve:945:10)
    at defaultResolve (node:internal/modules/esm/resolve:1153:11)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:838:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:77:40)
    at link (node:internal/modules/esm/module_job:76:36)

@leerob
Copy link
Member

leerob commented Aug 24, 2023

This should not be needed. I was not able to reproduce. Could you please open an issue with a minimal reproduction?

@uzairali001
Copy link
Contributor Author

I've opened the issue #54491 and provided the repo which reproduces this issue.

@balazsorban44
Copy link
Member

I think this is valid @leerob, I'm able to reproduce it.

#42144 intended to update it this way, but #53100 reverted the change in this PR by accident.

This would be required as noted by @uzairali001 currently, since we are missing the exports field from next.

@balazsorban44 balazsorban44 reopened this Aug 24, 2023
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@kodiakhq kodiakhq bot merged commit 32f11c3 into vercel:canary Aug 24, 2023
@uzairali001 uzairali001 deleted the uzairali001-patch-1 branch August 24, 2023 12:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants