Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Examples) update Grafbase example #54705

Merged
merged 17 commits into from
Sep 30, 2023
Merged

(Examples) update Grafbase example #54705

merged 17 commits into from
Sep 30, 2023

Conversation

vinaykulk621
Copy link
Contributor

No description provided.

@vinaykulk621 vinaykulk621 requested review from a team as code owners August 29, 2023 08:17
@ijjk ijjk added the examples Issue was opened via the examples template. label Aug 29, 2023
@ijjk
Copy link
Member

ijjk commented Aug 29, 2023

Allow CI Workflow Run

  • approve CI run for commit: 3aa5aeb

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, remember to run pnpm lint when updating an example

examples/with-grafbase/app/layout.tsx Outdated Show resolved Hide resolved
examples/with-grafbase/app/layout.tsx Outdated Show resolved Hide resolved
examples/with-grafbase/app/layout.tsx Outdated Show resolved Hide resolved
@vinaykulk621
Copy link
Contributor Author

@balazsorban44 Any updates on this??

balazsorban44
balazsorban44 previously approved these changes Sep 4, 2023
@balazsorban44
Copy link
Member

Thanks, note that you don't need to keep merging canary, it won't result in a faster merge. 👍

leerob
leerob previously approved these changes Sep 26, 2023
@leerob
Copy link
Member

leerob commented Sep 26, 2023

Linting is failing here, FYI

@vinaykulk621 vinaykulk621 dismissed stale reviews from balazsorban44 and leerob via 46ba6f3 September 26, 2023 07:17
@vinaykulk621 vinaykulk621 requested a review from leerob September 26, 2023 13:09
@vinaykulk621
Copy link
Contributor Author

@leerob Fixed linting errors

leerob
leerob previously approved these changes Sep 26, 2023
@vinaykulk621
Copy link
Contributor Author

@leerob this time i fixed it believe me, please!!

leerob
leerob previously approved these changes Sep 26, 2023
leerob
leerob previously approved these changes Sep 27, 2023
@leerob
Copy link
Member

leerob commented Sep 27, 2023

Did you fix the Prettier errors? It's still failing. Are you validating locally? 🙏

@vinaykulk621
Copy link
Contributor Author

I am validating in github codespace here is the video on how i am trying to do

Nothing seems to change here tho

2023-09-27.09-54-23.mp4

i tried running pnpm lint at the root directory but it's not working either

image

I tried to changing the pnpm version but it does not seem to work here.
It goes back to 8.6.1 even though i run pnpm i -g pnpm@8.7.1

i thought i should run it in the example directory where i am making changes but the example do not include lint script in package.json.

You could say i really have no idea where i should run pnpm lint.
Here in linting.md it is not specfied where i should i run this command when i update an examples.

Please help🙏🏻.

@manovotny
Copy link
Contributor

manovotny commented Sep 27, 2023

@vinaykulk621 try running corepack enable pnpm to get the pnpm versions in sync. Then, run pnpm prettier-fix from the root of the project and commit the changes.

@vinaykulk621
Copy link
Contributor Author

@manovotny @leerob Thank you!! Got it fixed!

@manovotny manovotny added the CI approved Approve running CI for fork label Sep 27, 2023
@vinaykulk621 vinaykulk621 requested a review from leerob September 30, 2023 10:59
@kodiakhq kodiakhq bot merged commit 638cc93 into vercel:canary Sep 30, 2023
50 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants