-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Examples) update Grafbase example #54705
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
Passed | Secrets | 0 0 0 0 | View in Orca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, remember to run pnpm lint
when updating an example
@balazsorban44 Any updates on this?? |
Thanks, note that you don't need to keep merging |
Linting is failing here, FYI |
46ba6f3
@leerob Fixed linting errors |
@leerob this time i fixed it believe me, please!! |
Did you fix the Prettier errors? It's still failing. Are you validating locally? 🙏 |
I am validating in github codespace here is the video on how i am trying to do Nothing seems to change here tho 2023-09-27.09-54-23.mp4i tried running I tried to changing the i thought i should run it in the example directory where i am making changes but the example do not include lint script in You could say i really have no idea where i should run Please help🙏🏻. |
@vinaykulk621 try running |
@manovotny @leerob Thank you!! Got it fixed! |
No description provided.