Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(turbopack): support next.js specific node polyfills" #55385

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Sep 14, 2023

Reverts #55343

Closes WEB-1562

it fails CI with:

  ● node builtins › should support node.js builtins in server component
  
      SyntaxError: Unexpected end of JSON input
          at JSON.parse (<anonymous>)
  
        124 |
        125 |       const data = $('#node-browser-polyfills').text()
      > 126 |       const parsedData = JSON.parse(data)
            |                               ^
        127 |
        128 |       expect(parsedData.vm).toBe(105)
        129 |       expect(parsedData.hash).toBe(
  
        at Object.<anonymous> (development/basic/node-builtins.test.ts:126:31)
  
    ● node builtins › should support node.js builtins prefixed by node: in server component
  
      SyntaxError: Unexpected end of JSON input
          at JSON.parse (<anonymous>)
  
        149 |
        150 |       const data = $('#node-browser-polyfills').text()
      > 151 |       const parsedData = JSON.parse(data)
            |                               ^
        152 |
        153 |       expect(parsedData.vm).toBe(105)
        154 |       expect(parsedData.hash).toBe(
  
        at Object.<anonymous> (development/basic/node-builtins.test.ts:151:31)
  

@kwonoj

@linear
Copy link

linear bot commented Sep 14, 2023

@ijjk ijjk added area: tests Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the Turbopack team. type: next labels Sep 14, 2023
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 1   low 0   info 0 View in Orca

@sokra sokra merged commit 9953db4 into canary Sep 14, 2023
14 of 17 checks passed
@sokra sokra deleted the revert-55343-node-builtins-turbopack branch September 14, 2023 13:16
sokra added a commit that referenced this pull request Sep 14, 2023
sokra added a commit that referenced this pull request Sep 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants