Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): remove deprecated dependency from with-jest #56152

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

Loki899899
Copy link
Contributor

Fixes #56151
Tests added: none
Errors: https://ibb.co/MnTDChy

@testing-library/jest-dom provides its own type definitions

@types/testing-library__jest-dom has been deprecated
ref: https://www.npmjs.com/package/@types/testing-library__jest-dom

Fixes vercel#56151
Tests added: none
Errors: https://ibb.co/MnTDChy

@testing-library/jest-dom provides its own type definitions and package @types/testing-library__jest-dom has been deprecated
ref: https://www.npmjs.com/package/@types/testing-library__jest-dom
@Loki899899 Loki899899 requested review from a team as code owners September 28, 2023 11:26
@Loki899899 Loki899899 requested review from S3Prototype and leerob and removed request for a team September 28, 2023 11:26
@ijjk ijjk added the examples Issue was opened via the examples template. label Sep 28, 2023
@balazsorban44 balazsorban44 changed the title Fixes #56151 chore(examples): remove deprecated dependency from with-jest Sep 28, 2023
@ijjk
Copy link
Member

ijjk commented Sep 28, 2023

Allow CI Workflow Run

  • approve CI run for commit: aa56271

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Sep 28, 2023

Allow CI Workflow Run

  • approve CI run for commit: aa56271

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@kodiakhq kodiakhq bot merged commit a623685 into vercel:canary Sep 29, 2023
51 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm run build fails in example with-jest
4 participants