test: ability to use node debugger #56277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomfa
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
tomfa
changed the title
|
@escherstair I think I fixed it in #57159 |
And so this PR is not necessary anymore? |
|
Hi @feedthejim |
|
@feedthejim still not working in v14, right? so probably not fixed from #57159 |
huozhi
reviewed
Dec 7, 2023
huozhi
changed the title
|
Looks like it's already fixed on canary, I merged the canary branch and updated the PR title. Thanks for adding the test! |
huozhi
approved these changes
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ability to run
NODE_OPTIONS='--inspect' next devas described in docs, by removing inspect option from NODE_OPTIONS arg passed to worker process.This bug seem to have been introduced in 7d93808 as a part of a some refactoring. See how
getNodeOptionsWithoutInspectis no longer used.Fixes #55862