Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .yarn/install-state.gz to .gitignore #56637

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

leung018
Copy link
Contributor

Reason for making this change

https://yarnpkg.com/getting-started/qa#:~:text=yarn%2Finstall%2Dstate.,your%20workspaces%20all%20over%20again.
In the official documentation of yarn, it is stated that .yarn/install-state.gz is an optimization file that developer shouldn't ever have to commit. However, currently, when running create-next-app, .yarn/install-state.gz is being commited.

Remaining work

I apologize for only modifying one template initially to initiate the discussion first.

If this change is agreed upon, it should be synchronized with other .gitignore templates. Would it be possible to follow a similar approach as in #47241? I would appreciate any assistance in syncing this change.

@leung018 leung018 requested a review from a team as a code owner October 10, 2023 05:51
@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Oct 10, 2023
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this to all the templates

@leung018 leung018 requested review from jh3y, lydiahallie and styfle and removed request for a team October 18, 2023 07:22
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 🎉

@styfle styfle added the CI approved Approve running CI for fork label Oct 18, 2023
@ijjk
Copy link
Member

ijjk commented Oct 18, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 18, 2023

Stats from current PR

Default Build
General
vercel/next.js canary leung018/next.js update-create-next-app-gitignore Change
buildDuration 10.4s 10.4s N/A
buildDurationCached 6.1s 6.2s N/A
nodeModulesSize 174 MB 174 MB
nextStartRea..uration (ms) 526ms 531ms N/A
Client Bundles (main, webpack)
vercel/next.js canary leung018/next.js update-create-next-app-gitignore Change
199-HASH.js gzip 27.5 kB 27.5 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 252 B 252 B
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary leung018/next.js update-create-next-app-gitignore Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary leung018/next.js update-create-next-app-gitignore Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.35 kB 4.35 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary leung018/next.js update-create-next-app-gitignore Change
_buildManifest.js gzip 485 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary leung018/next.js update-create-next-app-gitignore Change
index.html gzip 527 B 529 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 523 B 524 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary leung018/next.js update-create-next-app-gitignore Change
edge-ssr.js gzip 93.6 kB 93.6 kB N/A
page.js gzip 154 kB 154 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary leung018/next.js update-create-next-app-gitignore Change
middleware-b..fest.js gzip 624 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.5 kB 22.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: ac9f24c

@kodiakhq kodiakhq bot merged commit 66597be into vercel:canary Oct 18, 2023
52 of 57 checks passed
@leung018
Copy link
Contributor Author

Thanks for the review and merge!

@github-actions github-actions bot added the locked label Nov 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork create-next-app Related to our CLI tool for quickly starting a new Next.js application. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants