-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .yarn/install-state.gz to .gitignore #56637
Merged
kodiakhq
merged 5 commits into
vercel:canary
from
leung018:update-create-next-app-gitignore
Oct 18, 2023
Merged
Add .yarn/install-state.gz to .gitignore #56637
kodiakhq
merged 5 commits into
vercel:canary
from
leung018:update-create-next-app-gitignore
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
the
create-next-app
Related to our CLI tool for quickly starting a new Next.js application.
label
Oct 10, 2023
styfle
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this to all the templates
leung018
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
ztanner,
a team,
feedthejim and
wyattjoh
as code owners
October 18, 2023 07:21
leung018
requested review from
jh3y,
lydiahallie and
styfle
and removed request for
a team
October 18, 2023 07:22
styfle
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! 🎉
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
Thanks for the review and merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CI approved
Approve running CI for fork
create-next-app
Related to our CLI tool for quickly starting a new Next.js application.
locked
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for making this change
https://yarnpkg.com/getting-started/qa#:~:text=yarn%2Finstall%2Dstate.,your%20workspaces%20all%20over%20again.
In the official documentation of
yarn
, it is stated that.yarn/install-state.gz
is an optimization file that developer shouldn't ever have to commit. However, currently, when runningcreate-next-app
,.yarn/install-state.gz
is being commited.Remaining work
I apologize for only modifying one template initially to initiate the discussion first.
If this change is agreed upon, it should be synchronized with other
.gitignore
templates. Would it be possible to follow a similar approach as in #47241? I would appreciate any assistance in syncing this change.