Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create template from next-edge-ssr-loader #56715

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Oct 11, 2023

Description

  • Splits the generated code of the next-edge-ssr-loader out into 2 templates
  • This PR also adds support for optional imports in templates

Closes WEB-1761

@ijjk
Copy link
Member

ijjk commented Oct 11, 2023

Tests Passed

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/template-edge-ssr-loader branch from b773e65 to 6ea3ba1 Compare October 13, 2023 17:14
@ForsakenHarmony
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review October 13, 2023 18:01
@ijjk
Copy link
Member

ijjk commented Oct 13, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js hrmny/template-edge-ssr-loader Change
buildDuration 10.3s 10.2s N/A
buildDurationCached 6.1s 6.1s N/A
nodeModulesSize 174 MB 174 MB ⚠️ +47.4 kB
nextStartRea..uration (ms) 500ms 497ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js hrmny/template-edge-ssr-loader Change
199-HASH.js gzip 27.6 kB 27.6 kB
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 254 B 251 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 126 kB 126 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js hrmny/template-edge-ssr-loader Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js hrmny/template-edge-ssr-loader Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.36 kB 4.36 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary vercel/next.js hrmny/template-edge-ssr-loader Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js hrmny/template-edge-ssr-loader Change
index.html gzip 527 B 529 B N/A
link.html gzip 542 B 541 B N/A
withRouter.html gzip 525 B 525 B
Overall change 525 B 525 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js hrmny/template-edge-ssr-loader Change
edge-ssr.js gzip 94 kB 93.9 kB N/A
page.js gzip 155 kB 155 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js hrmny/template-edge-ssr-loader Change
middleware-b..fest.js gzip 622 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Diff details
Diff for page.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Commit: 1bd66f8

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/template-edge-ssr-loader branch from 4dbfcd9 to 6713a53 Compare October 13, 2023 18:55
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/template-edge-ssr-loader branch 2 times, most recently from 0f96b82 to 66c1649 Compare October 16, 2023 15:24
@ForsakenHarmony ForsakenHarmony changed the title WIP: create template from edge-ssr-loader chore: create template from edge-ssr-loader Oct 16, 2023
@ForsakenHarmony ForsakenHarmony changed the title chore: create template from edge-ssr-loader chore: create template from next-edge-ssr-loader Oct 16, 2023
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/template-edge-ssr-loader branch from 66c1649 to 3d6c7f1 Compare October 16, 2023 16:38
@@ -422,7 +422,7 @@ export function getEdgeServerEntry(opts: {
}

return {
import: `next-edge-ssr-loader?${stringify(loaderParams)}!`,
import: `next-edge-ssr-loader?${JSON.stringify(loaderParams)}!`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These needs to be querystring stringified as the parsing doesn't use JSON.

Copy link
Contributor Author

@ForsakenHarmony ForsakenHarmony Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it after looking it up and seeing that webpack supports json as well
See: https://webpack.js.org/concepts/loaders/#inline

the tests are also passing so it's working?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timneutkens might affect how webpack-internal references for this loader look like

@ijjk ijjk added the Turbopack Related to Turbopack with Next.js. label Oct 20, 2023
@kodiakhq kodiakhq bot merged commit 2f2e8e2 into canary Oct 20, 2023
53 of 58 checks passed
@kodiakhq kodiakhq bot deleted the hrmny/template-edge-ssr-loader branch October 20, 2023 20:19
@github-actions github-actions bot added the locked label Nov 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants