Utilize Promise.withResolvers #56764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Diff detailsDiff for page.jsDiff too large to display Diff for edge-ssr.jsDiff too large to display |
wyattjoh
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi,
ztanner,
a team and
feedthejim
as code owners
wyattjoh
requested review from
ismaelrumzan and
Nutlope
and removed request for
a team
wyattjoh
commented
Oct 12, 2023
| @@ -794,16 +794,3 @@ export async function getImageSize( | |||
| const { width, height } = imageSizeOf(buffer) | |||
| return { width, height } | |||
| } | |||
|
|
|||
| export class Deferred<T> { | |||
There was a problem hiding this comment.
I think this was leftover from something long ago, so it can be removed 😅
Comment on lines
-44
to
-46
| let resolver: (cacheEntry: ResponseCacheEntry | null) => void = () => {} | ||
| let rejecter: (error: Error) => void = () => {} | ||
| const promise: Promise<ResponseCacheEntry | null> = new Promise( |
There was a problem hiding this comment.
Now we can use the types returned by Promise.withResolvers!
styfle
reviewed
Oct 12, 2023
| this.setDevReady!() | ||
|
|
||
| this.ready?.resolve() | ||
| this.ready = undefined |
There was a problem hiding this comment.
Any reason this is set to undefined?
There was a problem hiding this comment.
Because we didn't want to permit resolving more than once or rejecting after the value was resolved, this setting it to undefined was to act as a signal that the "value isn't of use anymore". Ideally, we'd want to do if (this.ready) await this.ready.promise to improve the performance, as it would allow us to avoid the await and subsequent yielding to the event loop.
styfle
approved these changes
Oct 12, 2023
Tests Passed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utilizes
Promise.withResolversin a few places where it was done the old way. This also rearranges some imports and typings.