Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test case less flaky #57138

Merged
merged 2 commits into from
Oct 20, 2023
Merged

make test case less flaky #57138

merged 2 commits into from
Oct 20, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 20, 2023

What?

test case is flaky

Why?

How?

Closes WEB-1813

@ijjk ijjk added area: tests created-by: Turbopack team PRs by the Turbopack team. labels Oct 20, 2023
@ijjk
Copy link
Member

ijjk commented Oct 20, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 20, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sokra/test-stability-2 Change
buildDuration 10.5s 10.6s ⚠️ +115ms
buildDurationCached 6.2s 6.3s ⚠️ +123ms
nodeModulesSize 174 MB 174 MB
nextStartRea..uration (ms) 513ms 496ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/test-stability-2 Change
199-HASH.js gzip 27.5 kB 27.5 kB
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 253 B 252 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 126 kB 126 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/test-stability-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/test-stability-2 Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.36 kB 4.36 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/test-stability-2 Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/test-stability-2 Change
index.html gzip 527 B 529 B N/A
link.html gzip 542 B 541 B N/A
withRouter.html gzip 525 B 525 B
Overall change 525 B 525 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/test-stability-2 Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 155 kB 155 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/test-stability-2 Change
middleware-b..fest.js gzip 623 B 621 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: bd277b6

@sokra sokra marked this pull request as ready for review October 20, 2023 17:43
@sokra sokra requested a review from wbinnssmith October 20, 2023 17:45
@sokra sokra merged commit a63c749 into canary Oct 20, 2023
55 of 58 checks passed
@sokra sokra deleted the sokra/test-stability-2 branch October 20, 2023 17:46
@github-actions github-actions bot added the locked label Nov 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants