Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve server actions error when on unsupported node version #57191

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Oct 21, 2023

When using server actions on an unsupported version of Node, you might see the following errors:

NotSupportedError: multipart/form-data not supported

Support in Undici was landed in 5.11.0 which made it into Node v18.11.0

TypeError: e._formData.forEach is not a function

Earlier versions of v18 (such as 18.0.0) did not have a .forEach implementation on FormData

This throws a better error before the user can get to the point of seeing these more confusing errors.

Closes NEXT-1658
Fixes #55932

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 21, 2023
@ijjk
Copy link
Member

ijjk commented Oct 21, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/form-data-error Change
buildDuration 10.5s 10.4s N/A
buildDurationCached 5.9s 6.2s ⚠️ +231ms
nodeModulesSize 174 MB 174 MB ⚠️ +2.94 kB
nextStartRea..uration (ms) 530ms 520ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/form-data-error Change
199-HASH.js gzip 27.6 kB 27.6 kB
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 126 kB 126 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/form-data-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/form-data-error Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.36 kB 4.36 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/form-data-error Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/form-data-error Change
index.html gzip 528 B 529 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 523 B 524 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix/form-data-error Change
edge-ssr.js gzip 93.8 kB 93.8 kB N/A
page.js gzip 155 kB 155 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js fix/form-data-error Change
middleware-b..fest.js gzip 624 B 622 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 24.9 kB 24.9 kB
Commit: ed13d57

@ztanner ztanner marked this pull request as ready for review October 21, 2023 19:20
@kodiakhq kodiakhq bot merged commit eae65fa into canary Oct 21, 2023
53 of 58 checks passed
@kodiakhq kodiakhq bot deleted the fix/form-data-error branch October 21, 2023 19:32
@github-actions github-actions bot added the locked label Nov 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server Actions - ⨯ TypeError: e._formData.forEach is not a function
3 participants