-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(next_core): align remove trailing slash #57344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
a team
as code owners
October 24, 2023 16:44
ijjk
added
Turbopack
Related to Turbopack with Next.js.
created-by: Turbopack team
PRs by the Turbopack team.
type: next
labels
Oct 24, 2023
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
kwonoj
force-pushed
the
fix-trailing-slash
branch
from
October 24, 2023 18:40
9cde341
to
69fac05
Compare
kwonoj
commented
Oct 24, 2023
"Concurrent mode in the experimental-edge runtime dev flushes styled-jsx styles as the page renders", | ||
"Concurrent mode in the experimental-edge runtime dev should not have invalid config warning", | ||
"Concurrent mode in the nodejs runtime dev <RouteAnnouncer /> should not have the initial route announced", | ||
"Concurrent mode in the nodejs runtime dev flushes styled-jsx styles as the page renders", | ||
"Concurrent mode in the nodejs runtime dev should not have invalid config warning" | ||
], | ||
"failed": [], | ||
"failed": [ | ||
"Concurrent mode in the experimental-edge runtime dev <RouteAnnouncer /> should not have the initial route announced" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test never passed actually:
the assertion is to check if rendered page does not have a string (
expect(context.stderr).not.toContain('not exist in this version') |
sokra
approved these changes
Oct 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Turbopack team
PRs by the Turbopack team.
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
minor fix to match behavior to https://github.com/vercel/next.js/blob/ae10b5c82b29b3b077378f05f75eb1b215b327f0/packages/next/src/shared/lib/router/utils/remove-trailing-slash.ts#L2C4-L9
as we're seeing a panic when route is /
Closes WEB-1841