-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import antd from es in modularizeImports #57968
Conversation
mark |
Notifying the following users due to files changed in this PR based on this repo's notify modifiers: @timneutkens, @ijjk, @shuding, @huozhi:
|
Hi guys @timneutkens @huozhi , could you take a look at this PR? Currently cssinjs of antd breaks due to multiple context instances and this could help solve this problem. |
Same,seems problem with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
Diff detailsDiff for page.jsDiff too large to display Diff for edge-ssr.jsDiff too large to display |
I'm having the same error "Cannot use import statement outside a module" |
This fix doesn't allow to run Antd projects anymore with the latest Next.js. Can confirm, that if this PR is reverted everything works fine. Tested with refine: |
Same here. I am getting:
in regards of the and design imports. Any solution for this? |
There is a PR with a fix for this but it has merge conflicts and haven't been touched in 3 weeks |
Code from the main branch was already changed, but the issue is still there 😄 |
Fixing a bug
Currently any imports from antd will be replaced with
lib
, which will cause context not the same.Ref: ant-design/ant-design#45567