Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import antd from es in modularizeImports #57968

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

MadCcc
Copy link
Contributor

@MadCcc MadCcc commented Nov 3, 2023

Fixing a bug

Currently any imports from antd will be replaced with lib, which will cause context not the same.

Ref: ant-design/ant-design#45567

@MadCcc MadCcc requested review from manovotny and delbaoliveira and removed request for a team November 3, 2023 04:00
@ijjk ijjk added examples Issue was opened via the examples template. type: next labels Nov 3, 2023
@li-jia-nan
Copy link
Contributor

mark

Copy link

vercel-spaces bot commented Nov 7, 2023

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @huozhi:

packages/next/src/server/config.ts

@MadCcc
Copy link
Contributor Author

MadCcc commented Nov 8, 2023

Hi guys @timneutkens @huozhi , could you take a look at this PR? Currently cssinjs of antd breaks due to multiple context instances and this could help solve this problem.

@ondery
Copy link

ondery commented Nov 8, 2023

now, it starts to import <style id="antd"> multiple times... :(( One time in head, multiple times in body tag.

image

@MadCcc
Copy link
Contributor Author

MadCcc commented Nov 9, 2023

now, it starts to import <style id="antd"> multiple times... :(( One time in head, multiple times in body

Same,seems problem with useServerInsertedHTML ?

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Nov 13, 2023

Stats from current PR

Default Build
General
vercel/next.js canary MadCcc/next.js fix/antd Change
buildDuration 10.3s 10.5s ⚠️ +208ms
buildDurationCached 6.1s 6.1s N/A
nodeModulesSize 199 MB 199 MB N/A
nextStartRea..uration (ms) 401ms 402ms N/A
Client Bundles (main, webpack)
vercel/next.js canary MadCcc/next.js fix/antd Change
199-HASH.js gzip 29.1 kB 29.1 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB N/A
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 46.9 kB 46.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary MadCcc/next.js fix/antd Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary MadCcc/next.js fix/antd Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 504 B 506 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.3 kB 4.3 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.65 kB 2.65 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary MadCcc/next.js fix/antd Change
_buildManifest.js gzip 486 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary MadCcc/next.js fix/antd Change
index.html gzip 528 B 526 B N/A
link.html gzip 540 B 541 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary MadCcc/next.js fix/antd Change
edge-ssr.js gzip 92.5 kB 92.5 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary MadCcc/next.js fix/antd Change
middleware-b..fest.js gzip 625 B 627 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 26.7 kB 26.7 kB
Next Runtimes
vercel/next.js canary MadCcc/next.js fix/antd Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 93.2 kB 93.2 kB
app-page-tur..prod.js gzip 93.9 kB 93.9 kB
app-page-tur..prod.js gzip 88.5 kB 88.5 kB
app-page.run...dev.js gzip 137 kB 137 kB
app-page.run..prod.js gzip 87.9 kB 87.9 kB
app-route-ex...dev.js gzip 23.8 kB 23.8 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 23.2 kB 23.2 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.8 kB 21.8 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.8 kB 21.8 kB
server.runti..prod.js gzip 48.8 kB 48.8 kB
Overall change 922 kB 922 kB
Diff details
Diff for page.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Commit: c4bc5b2

@hjdskhooba
Copy link

I'm having the same error "Cannot use import statement outside a module"

@w20k
Copy link

w20k commented Dec 7, 2023

This fix doesn't allow to run Antd projects anymore with the latest Next.js.
It's throwing errors: Unexpected token export or Cannot use import.

Can confirm, that if this PR is reverted everything works fine. Tested with refine:
Screenshot_2023-12-07_at_20_21_52-2

@ussuritiger
Copy link

Same here. I am getting:

SyntaxError: Cannot use import statement outside a module

in regards of the and design imports.

Any solution for this?

@Markus-ipse
Copy link

There is a PR with a fix for this but it has merge conflicts and haven't been touched in 3 weeks
#58992

@w20k
Copy link

w20k commented Dec 20, 2023

There is a PR with a fix for this but it has merge conflicts and haven't been touched in 3 weeks #58992

Code from the main branch was already changed, but the issue is still there 😄

@github-actions github-actions bot added the locked label Jan 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants