-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip flushToDisk in minimal mode for fetch cache #58516
Merged
kodiakhq
merged 2 commits into
canary
from
11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache
Nov 16, 2023
Merged
skip flushToDisk in minimal mode for fetch cache #58516
kodiakhq
merged 2 commits into
canary
from
11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
ztanner
force-pushed
the
11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache
branch
from
November 16, 2023 00:40
5b721c8
to
844f1d6
Compare
Stats from current PRDefault BuildGeneral Overall increase
|
vercel/next.js canary | vercel/next.js 11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache | Change | |
---|---|---|---|
buildDuration | 10.3s | 10.4s | N/A |
buildDurationCached | 6s | 6.8s | |
nodeModulesSize | 199 MB | 199 MB | |
nextStartRea..uration (ms) | 399ms | 401ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache | Change | |
---|---|---|---|
199-HASH.js gzip | 29.2 kB | 29.2 kB | N/A |
3f784ff6-HASH.js gzip | 53.3 kB | 53.3 kB | N/A |
494.HASH.js gzip | 180 B | 181 B | N/A |
framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
main-app-HASH.js gzip | 242 B | 239 B | N/A |
main-HASH.js gzip | 31.7 kB | 31.8 kB | N/A |
webpack-HASH.js gzip | 1.7 kB | 1.7 kB | ✓ |
Overall change | 46.9 kB | 46.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache | Change | |
---|---|---|---|
_app-HASH.js gzip | 194 B | 195 B | N/A |
_error-HASH.js gzip | 182 B | 181 B | N/A |
amp-HASH.js gzip | 504 B | 506 B | N/A |
css-HASH.js gzip | 322 B | 323 B | N/A |
dynamic-HASH.js gzip | 2.5 kB | 2.5 kB | ✓ |
edge-ssr-HASH.js gzip | 253 B | 255 B | N/A |
head-HASH.js gzip | 348 B | 347 B | N/A |
hooks-HASH.js gzip | 369 B | 368 B | N/A |
image-HASH.js gzip | 4.3 kB | 4.3 kB | N/A |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.65 kB | 2.65 kB | N/A |
routerDirect..HASH.js gzip | 311 B | 311 B | ✓ |
script-HASH.js gzip | 384 B | 383 B | N/A |
withRouter-HASH.js gzip | 307 B | 308 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.17 kB | 3.17 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache | Change | |
---|---|---|---|
_buildManifest.js gzip | 486 B | 484 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache | Change | |
---|---|---|---|
index.html gzip | 528 B | 526 B | N/A |
link.html gzip | 542 B | 542 B | ✓ |
withRouter.html gzip | 524 B | 521 B | N/A |
Overall change | 542 B | 542 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache | Change | |
---|---|---|---|
edge-ssr.js gzip | 92.6 kB | 92.6 kB | N/A |
page.js gzip | 145 kB | 145 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 625 B | 627 B | N/A |
middleware-r..fest.js gzip | 150 B | 151 B | N/A |
middleware.js gzip | 24.8 kB | 24.8 kB | ✓ |
edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
Overall change | 26.7 kB | 26.7 kB | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js 11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 167 kB | 167 kB | ✓ |
app-page-exp..prod.js gzip | 93.2 kB | 93.2 kB | ✓ |
app-page-tur..prod.js gzip | 93.9 kB | 93.9 kB | ✓ |
app-page-tur..prod.js gzip | 88.5 kB | 88.5 kB | ✓ |
app-page.run...dev.js gzip | 137 kB | 137 kB | ✓ |
app-page.run..prod.js gzip | 87.9 kB | 87.9 kB | ✓ |
app-route-ex...dev.js gzip | 23.8 kB | 23.8 kB | ✓ |
app-route-ex..prod.js gzip | 16.4 kB | 16.4 kB | ✓ |
app-route-tu..prod.js gzip | 16.4 kB | 16.4 kB | ✓ |
app-route-tu..prod.js gzip | 16 kB | 16 kB | ✓ |
app-route.ru...dev.js gzip | 23.2 kB | 23.2 kB | ✓ |
app-route.ru..prod.js gzip | 16 kB | 16 kB | ✓ |
pages-api-tu..prod.js gzip | 9.37 kB | 9.37 kB | ✓ |
pages-api.ru...dev.js gzip | 9.64 kB | 9.64 kB | ✓ |
pages-api.ru..prod.js gzip | 9.37 kB | 9.37 kB | ✓ |
pages-turbo...prod.js gzip | 21.8 kB | 21.8 kB | ✓ |
pages.runtim...dev.js gzip | 22.5 kB | 22.5 kB | ✓ |
pages.runtim..prod.js gzip | 21.8 kB | 21.8 kB | ✓ |
server.runti..prod.js gzip | 49 kB | 49 kB | ✓ |
Overall change | 923 kB | 923 kB | ✓ |
ztanner
force-pushed
the
11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache
branch
from
November 16, 2023 01:28
844f1d6
to
17c94ec
Compare
Tests Passed |
ztanner
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim and
wyattjoh
as code owners
November 16, 2023 02:10
ijjk
approved these changes
Nov 16, 2023
kodiakhq
bot
deleted the
11-15-skip_flushToDisk_in_minimal_mode_for_fetch_cache
branch
November 16, 2023 02:34
TranquilMarmot
pushed a commit
to TranquilMarmot/next.js
that referenced
this pull request
Nov 24, 2023
Follow-up to vercel#58516 where a few spots where missed. This is only disabled in minimal mode. [Slack context](https://vercel.slack.com/archives/C042LHPJ1NX/p1700756778718459)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This temporarily disables flushing fetch cache to disk during builds in minimal mode as some additional changes are needed to support it better.
slack context