Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): workaround for intermittent locks on windows when renaming files #58835

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

ForsakenHarmony
Copy link
Contributor

What?

See: libuv/libuv#1981

Closes PACK-1956
Fixes #57581

@ijjk
Copy link
Member

ijjk commented Nov 23, 2023

Tests Passed

sokra
sokra previously approved these changes Nov 23, 2023
@ijjk
Copy link
Member

ijjk commented Nov 23, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js hrmny/pack-1956-eperm-renaming Change
buildDuration 10.4s 10.2s N/A
buildDurationCached 5.8s 5.8s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +60.1 kB
nextStartRea..uration (ms) 419ms 436ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js hrmny/pack-1956-eperm-renaming Change
199-HASH.js gzip 28.7 kB 28.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 240 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js hrmny/pack-1956-eperm-renaming Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js hrmny/pack-1956-eperm-renaming Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js hrmny/pack-1956-eperm-renaming Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js hrmny/pack-1956-eperm-renaming Change
index.html gzip 528 B 527 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 523 B N/A
Overall change 541 B 541 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js hrmny/pack-1956-eperm-renaming Change
edge-ssr.js gzip 92.4 kB 92.4 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js hrmny/pack-1956-eperm-renaming Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 35.7 kB 35.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.55 kB 2.55 kB
Next Runtimes
vercel/next.js canary vercel/next.js hrmny/pack-1956-eperm-renaming Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 93.3 kB 93.3 kB
app-page-tur..prod.js gzip 94.1 kB 94.1 kB
app-page-tur..prod.js gzip 88.6 kB 88.6 kB
app-page.run...dev.js gzip 137 kB 137 kB
app-page.run..prod.js gzip 88 kB 88 kB
app-route-ex...dev.js gzip 23.8 kB 23.8 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.5 kB 16.5 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 23.2 kB 23.2 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.8 kB 21.8 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.8 kB 21.8 kB
server.runti..prod.js gzip 49.1 kB 49.1 kB
Overall change 924 kB 924 kB
Commit: a08c8d2

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-1956-eperm-renaming branch from c894f7e to 7dbf384 Compare November 23, 2023 20:48
@ForsakenHarmony ForsakenHarmony requested a review from a team as a code owner November 23, 2023 20:48
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-1956-eperm-renaming branch 5 times, most recently from b061368 to 3224096 Compare November 24, 2023 16:50
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-1956-eperm-renaming branch from 3224096 to 049db78 Compare November 24, 2023 16:56
@ForsakenHarmony ForsakenHarmony merged commit 40a6e61 into canary Nov 27, 2023
60 checks passed
@ForsakenHarmony ForsakenHarmony deleted the hrmny/pack-1956-eperm-renaming branch November 27, 2023 15:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The turbo package in nextjs 14 has a bug: EPERM: operation not permitted
3 participants