-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gracefully handle client router segment mismatches #60141
Merged
ztanner
merged 4 commits into
canary
from
01-02-gracefully_handle_client_router_segment_mismatches
Jan 3, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
858f563
gracefully handle client router segment mismatches
ztanner 2aa5a95
Merge branch 'canary' into 01-02-gracefully_handle_client_router_segm…
ztanner f758e3c
Update packages/next/src/client/components/router-reducer/handle-segm…
ztanner d506cc4
Merge branch 'canary' into 01-02-gracefully_handle_client_router_segm…
ztanner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
packages/next/src/client/components/router-reducer/handle-segment-mismatch.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import type { FlightRouterState } from '../../../server/app-render/types' | ||
import { handleExternalUrl } from './reducers/navigate-reducer' | ||
import type { | ||
ReadonlyReducerState, | ||
ReducerActions, | ||
} from './router-reducer-types' | ||
|
||
/** | ||
* Handles the case where the client router attempted to patch the tree but, due to a mismatch, the patch failed. | ||
* This will perform an MPA navigation to return the router to a valid state. | ||
*/ | ||
export function handleSegmentMismatch( | ||
state: ReadonlyReducerState, | ||
action: ReducerActions, | ||
treePatch: FlightRouterState | ||
) { | ||
if (process.env.NODE_ENV === 'development') { | ||
console.warn( | ||
'Performing hard navigation because your application experienced an unrecoverable error. If this keeps occurring, please file a Next.js issue.\n\n' + | ||
'Reason: Segment mismatch\n' + | ||
`Last Action: ${action.type}\n\n` + | ||
`Current Tree: ${JSON.stringify(state.tree)}\n\n` + | ||
`Tree Patch Payload: ${JSON.stringify(treePatch)}` | ||
) | ||
} | ||
|
||
return handleExternalUrl(state, {}, state.canonicalUrl, true) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice