Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always write FunctionsConfigManifest #60163

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Always write FunctionsConfigManifest #60163

merged 1 commit into from
Jan 4, 2024

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Jan 3, 2024 •
edited by padmaia
Loading

What?

Noticed there was a specific guard to avoid writing this manifest when there was no custom config, but for consistency in the output it's better to always write it.
Also added a type for this manifest.

Closes NEXT-1960

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 3, 2024
This was referenced Jan 3, 2024
Merged
Merged
Merged
Merged
@timneutkens
Copy link
Member Author

timneutkens commented Jan 3, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@timneutkens timneutkens mentioned this pull request Jan 3, 2024
Merged
@ijjk
Copy link
Member

ijjk commented Jan 3, 2024 •
edited
Loading

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-03-Always_write_FunctionsConfigManifest Change
buildDuration 12.9s 12.9s ✓
buildDurationCached 7.3s 6.1s N/A
nodeModulesSize 202 MB 202 MB ⚠️ +4.9 kB
nextStartRea..uration (ms) 427ms 431ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-03-Always_write_FunctionsConfigManifest Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB ✓
433-HASH.js gzip 28.4 kB 28.5 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-03-Always_write_FunctionsConfigManifest Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 01-03-Always_write_FunctionsConfigManifest Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.28 kB 4.28 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB ✓
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.4 kB 3.4 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 01-03-Always_write_FunctionsConfigManifest Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-03-Always_write_FunctionsConfigManifest Change
index.html gzip 528 B 526 B N/A
link.html gzip 541 B 538 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-03-Always_write_FunctionsConfigManifest Change
edge-ssr.js gzip 93.7 kB 93.8 kB N/A
page.js gzip 147 kB 147 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js 01-03-Always_write_FunctionsConfigManifest Change
middleware-b..fest.js gzip 624 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 37.4 kB 37.4 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 2.07 kB 2.07 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js 01-03-Always_write_FunctionsConfigManifest Change
app-page-exp...dev.js gzip 168 kB 168 kB ✓
app-page-exp..prod.js gzip 94.2 kB 94.2 kB ✓
app-page-tur..prod.js gzip 94.9 kB 94.9 kB ✓
app-page-tur..prod.js gzip 89.4 kB 89.4 kB ✓
app-page.run...dev.js gzip 138 kB 138 kB ✓
app-page.run..prod.js gzip 88.7 kB 88.7 kB ✓
app-route-ex...dev.js gzip 24.1 kB 24.1 kB ✓
app-route-ex..prod.js gzip 16.7 kB 16.7 kB ✓
app-route-tu..prod.js gzip 16.7 kB 16.7 kB ✓
app-route-tu..prod.js gzip 16.3 kB 16.3 kB ✓
app-route.ru...dev.js gzip 23.5 kB 23.5 kB ✓
app-route.ru..prod.js gzip 16.3 kB 16.3 kB ✓
pages-api-tu..prod.js gzip 9.38 kB 9.38 kB ✓
pages-api.ru...dev.js gzip 9.65 kB 9.65 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 22.5 kB 22.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 49.4 kB 49.4 kB ✓
Overall change 932 kB 932 kB ✓
Commit: 8f54d78

@timneutkens timneutkens force-pushed the 01-03-Add_writeStandaloneDirectory branch from 710401a to 3195377 Compare January 3, 2024 15:41
@timneutkens timneutkens force-pushed the 01-03-Always_write_FunctionsConfigManifest branch from 100c932 to 8f54d78 Compare January 3, 2024 15:41
@ijjk
Copy link
Member

ijjk commented Jan 3, 2024 •
edited
Loading

Tests Passed

@timneutkens timneutkens force-pushed the 01-03-Add_writeStandaloneDirectory branch from 3195377 to dd9b086 Compare January 4, 2024 10:22
Base automatically changed from 01-03-Add_writeStandaloneDirectory to canary January 4, 2024 10:23
@timneutkens timneutkens force-pushed the 01-03-Always_write_FunctionsConfigManifest branch from 8f54d78 to e4e565d Compare January 4, 2024 10:25
@timneutkens timneutkens merged commit bcbaf8c into canary Jan 4, 2024
12 of 17 checks passed
@timneutkens timneutkens deleted the 01-03-Always_write_FunctionsConfigManifest branch January 4, 2024 10:26
@samcx samcx mentioned this pull request Jan 6, 2024
Closed
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
@timneutkens @agustints
Always write FunctionsConfigManifest (vercel#60163)
8f966af 
## What?

Noticed there was a specific guard to avoid writing this manifest when
there was no custom config, but for consistency in the output it's
better to always write it.
Also added a type for this manifest.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-1960
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@ztanner ztanner Awaiting requested review from ztanner

@feedthejim feedthejim Awaiting requested review from feedthejim

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timneutkens @ijjk @huozhi