Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dev-overlay): remove chalk #60317

Merged
merged 3 commits into from
Jan 8, 2024
Merged

refactor(dev-overlay): remove chalk #60317

merged 3 commits into from
Jan 8, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Jan 6, 2024

Per @styfle suggestion, #58038 has been split into multiple PRs for easier review.

  • Remove chalk inside @next/react-dev-overlay

@ijjk
Copy link
Member

ijjk commented Jan 6, 2024

Stats from current PR

Default Build
General
vercel/next.js canary SukkaW/next.js remove-chalk Change
buildDuration 13.2s 13.2s N/A
buildDurationCached 7.3s 6.4s N/A
nodeModulesSize 199 MB 199 MB N/A
nextStartRea..uration (ms) 429ms 412ms N/A
Client Bundles (main, webpack)
vercel/next.js canary SukkaW/next.js remove-chalk Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB N/A
433-HASH.js gzip 28.6 kB 28.6 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 239 B 242 B N/A
main-HASH.js gzip 31.7 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.2 kB 45.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary SukkaW/next.js remove-chalk Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary SukkaW/next.js remove-chalk Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.28 kB 4.28 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary SukkaW/next.js remove-chalk Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary SukkaW/next.js remove-chalk Change
index.html gzip 527 B 527 B
link.html gzip 540 B 540 B
withRouter.html gzip 523 B 522 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary SukkaW/next.js remove-chalk Change
edge-ssr.js gzip 93.8 kB 93.8 kB N/A
page.js gzip 148 kB 148 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary SukkaW/next.js remove-chalk Change
middleware-b..fest.js gzip 625 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.4 kB 37.4 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary SukkaW/next.js remove-chalk Change
app-page-exp...dev.js gzip 169 kB 169 kB
app-page-exp..prod.js gzip 95.1 kB 95.1 kB
app-page-tur..prod.js gzip 95.8 kB 95.8 kB
app-page-tur..prod.js gzip 90.4 kB 90.4 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 89.7 kB 89.7 kB
app-route-ex...dev.js gzip 24.1 kB 24.1 kB
app-route-ex..prod.js gzip 16.7 kB 16.7 kB
app-route-tu..prod.js gzip 16.7 kB 16.7 kB
app-route-tu..prod.js gzip 16.3 kB 16.3 kB
app-route.ru...dev.js gzip 23.5 kB 23.5 kB
app-route.ru..prod.js gzip 16.3 kB 16.3 kB
pages-api-tu..prod.js gzip 9.38 kB 9.38 kB
pages-api.ru...dev.js gzip 9.65 kB 9.65 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.5 kB 49.5 kB
Overall change 939 kB 939 kB
Commit: 0206bf7

@ijjk
Copy link
Member

ijjk commented Jan 6, 2024

Failing test suites

Commit: 0206bf7

pnpm test test/production/prerender-prefetch/index.test.ts

  • Prerender prefetch > with optimisticClientCache enabled > should update cache using router.push with unstable_skipClientCache
Expand output

● Prerender prefetch › with optimisticClientCache enabled › should update cache using router.push with unstable_skipClientCache

expect(received).not.toBe(expected) // Object.is equality

Expected: not 1704750687310

  154 |         await browser.elementByCss('#props').text()
  155 |       ).now
> 156 |       expect(newTime).not.toBe(startTime)
      |                           ^
  157 |       expect(isNaN(newTime)).toBe(false)
  158 |     })
  159 |

  at Object.toBe (production/prerender-prefetch/index.test.ts:156:27)

Read more about building and testing Next.js in contributing.md.

@huozhi
Copy link
Member

huozhi commented Jan 8, 2024

Precompiled assets need to update

@styfle
Copy link
Member

styfle commented Jan 8, 2024

Maybe this could remove the dep and instead copy/paste the file from packages/next/src/lib/picocolors.ts

@ijjk ijjk enabled auto-merge (squash) January 8, 2024 21:34
@ijjk ijjk merged commit 0aa0179 into vercel:canary Jan 8, 2024
62 of 68 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2024
@SukkaW SukkaW deleted the remove-chalk branch June 28, 2024 02:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants