Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc_core to v0.87.28 #60876

Merged
merged 34 commits into from
Jan 24, 2024
Merged

Update swc_core to v0.87.28 #60876

merged 34 commits into from
Jan 24, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 19, 2024

Turbopack


What?

Update swc crates

Why?

Required for #57718.
styled-jsx crate now have a hook to transform CSS code using a Rust-side API

How?

Fixes #57718

Closes PACK-2256

@kdy1 kdy1 self-assigned this Jan 19, 2024
@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the Turbopack team. type: next labels Jan 19, 2024
@ijjk
Copy link
Member

ijjk commented Jan 19, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js kdy1/swc-core-87-3 Change
buildDuration 11.8s 11.8s N/A
buildDurationCached 6.4s 5.3s N/A
nodeModulesSize 200 MB 200 MB N/A
nextStartRea..uration (ms) 405ms 406ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/swc-core-87-3 Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
411-HASH.js gzip 29.8 kB 29.8 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.6 kB 98.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/swc-core-87-3 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/swc-core-87-3 Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/swc-core-87-3 Change
_buildManifest.js gzip 484 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/swc-core-87-3 Change
index.html gzip 528 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/swc-core-87-3 Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 149 kB 149 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/swc-core-87-3 Change
middleware-b..fest.js gzip 625 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/swc-core-87-3 Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.6 kB 95.6 kB
app-page-tur..prod.js gzip 96.3 kB 96.3 kB
app-page-tur..prod.js gzip 90.9 kB 90.9 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.2 kB 90.2 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.5 kB 14.5 kB
app-route.ru...dev.js gzip 21.6 kB 21.6 kB
app-route.ru..prod.js gzip 14.5 kB 14.5 kB
pages-api-tu..prod.js gzip 9.41 kB 9.41 kB
pages-api.ru...dev.js gzip 9.68 kB 9.68 kB
pages-api.ru..prod.js gzip 9.4 kB 9.4 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 932 kB 932 kB
Commit: 1f5c504

@kdy1 kdy1 force-pushed the kdy1/swc-core-87-3 branch from 5cc4835 to 747d103 Compare January 21, 2024 07:14
@ijjk
Copy link
Member

ijjk commented Jan 22, 2024

Failing test suites

Commit: 1f5c504

pnpm test-start test/e2e/prerender.test.ts (PPR)

  • Prerender > should not error when rewriting to fallback dynamic SSG page
Expand output

● Prerender › should not error when rewriting to fallback dynamic SSG page

TIMED OUT: /Post: post-100/



undefined

  636 |
  637 |   if (hardError) {
> 638 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  639 |   }
  640 |   return false
  641 | }

  at check (lib/next-test-utils.ts:638:11)
  at Object.<anonymous> (e2e/prerender.test.ts:944:7)

Read more about building and testing Next.js in contributing.md.

@kdy1 kdy1 force-pushed the kdy1/swc-core-87-3 branch from f5c2bac to c235e1e Compare January 22, 2024 09:19
@vercel vercel deleted a comment from ijjk Jan 22, 2024
@kdy1 kdy1 force-pushed the kdy1/swc-core-87-3 branch from 6718070 to b89db5a Compare January 23, 2024 01:40
@kdy1 kdy1 marked this pull request as ready for review January 23, 2024 02:43
@kdy1 kdy1 marked this pull request as draft January 23, 2024 02:43
@kdy1 kdy1 force-pushed the kdy1/swc-core-87-3 branch from eb62f00 to fc71e45 Compare January 24, 2024 03:44
@@ -226,15 +226,21 @@ export default function (next: NextInstance, render, fetch, ctx) {
const styleId = $('#blue-box').attr('class')
const style = $('style')

expect(style.text().includes(`p.${styleId}{color:blue`)).toBeTruthy()
expect(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nicer to read with toMatch

@kdy1 kdy1 changed the title Update swc_core to v0.87.27 Update swc_core to v0.87.28 Jan 24, 2024
kdy1 added a commit to vercel/turborepo that referenced this pull request Jan 24, 2024
### Description

next.js counterpart: vercel/next.js#60876

### Testing Instructions

See vercel/next.js#60876

- Closes PACK-2106
- Closes PACK-2257
@kdy1 kdy1 marked this pull request as ready for review January 24, 2024 05:34
@kdy1 kdy1 enabled auto-merge (squash) January 24, 2024 05:35
@kdy1 kdy1 merged commit 014b212 into canary Jan 24, 2024
69 checks passed
@kdy1 kdy1 deleted the kdy1/swc-core-87-3 branch January 24, 2024 08:05
@github-actions github-actions bot added the locked label Feb 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turbopack does not compile CSS nesting for styled-jsx
3 participants