Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improve and add new parallel routes examples #60981

Merged
merged 17 commits into from
Jan 26, 2024
Merged

Docs: Improve and add new parallel routes examples #60981

merged 17 commits into from
Jan 26, 2024

Conversation

delbaoliveira
Copy link
Contributor

@delbaoliveira delbaoliveira commented Jan 22, 2024

Continuing from: #60806

  • Update conditional routes example to render dashboard pages based on user's role (rather than checking if the user is logged in)
  • Add tab group example to allow each slot to be navigated independently.
  • Expand the modal example to show full implementation
    • Opening the modal
    • Closing the modal
  • Add catch-all slots example

Please merge after the diagrams PR: https://github.com/vercel/front/pull/28770

@delbaoliveira delbaoliveira marked this pull request as ready for review January 24, 2024 16:46
@delbaoliveira delbaoliveira requested review from a team as code owners January 24, 2024 16:46
@delbaoliveira delbaoliveira requested review from ismaelrumzan and timeyoutakeit and removed request for a team January 24, 2024 16:46
@ztanner
Copy link
Member

ztanner commented Jan 24, 2024

One use-case that might be worth documenting is catch-all slots. ie, you could have a sidebar that matches all sub-paths, rather than falling back to default, with @sidebar/[...catchAll]/page.tsx.

@delbaoliveira delbaoliveira marked this pull request as draft January 25, 2024 19:33
Copy link
Contributor

github-actions bot commented Jan 25, 2024

All broken links are now fixed, thank you!

@delbaoliveira
Copy link
Contributor Author

Converting the PR back to draft as we’re currently clarifying behaviour for […catchAll] and use cases for conditional routes.

@delbaoliveira delbaoliveira changed the title WIP: Improve and add new parallel routes examples Docs: Improve and add new parallel routes examples Jan 26, 2024
@delbaoliveira delbaoliveira marked this pull request as ready for review January 26, 2024 16:07
@leerob leerob merged commit 5fd0f38 into canary Jan 26, 2024
34 checks passed
@leerob leerob deleted the docs-8fjs branch January 26, 2024 18:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants