Don't emit crossorigin attributes for output: "export" by default

[tdanecker]

In other output modes, link and script tags do not contain a crossorigin attribute by default.

When using output: "export", it should also follow the other output modes, to avoid unnecessary CORS issues, especially when hosting the assets on a different domain (i.e. a CDN).

fixes #61210

[hsjobeki]

Encountering the same issue. Thanks for the fix. Hope this gets merged soon

[styfle]

Thanks for the PR!

It looks like there was a regression introduced when updating types here:

• Split prerending by route kind #55622

I think this was just a typo so should be safe to land assuming tests pass, thanks!

[ijjk]

Failing test suites

Commit: 43ee6b3

pnpm test test/integration/link-ref/test/index.test.js

• Invalid hrefs > production mode > should preload with child ref with function

Expand output

● Invalid hrefs › production mode › should preload with child ref with function

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  45 |     }
  46 |   }
> 47 |   expect(found).toBe(true)
     |                 ^
  48 |   await browser.close()
  49 | }
  50 |

  at toBe (integration/link-ref/test/index.test.js:47:17)
  at Object.<anonymous> (integration/link-ref/test/index.test.js:105:7)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	tdanecker/next.js bug/export-crossorigin	Change
buildDuration	14s	14s	N/A
buildDurationCached	7.6s	6.5s	N/A
nodeModulesSize	198 MB	198 MB	N/A
nextStartRea..uration (ms)	416ms	418ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	tdanecker/next.js bug/export-crossorigin	Change
2453-HASH.js gzip	30.2 kB	30.2 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	N/A
8299-HASH.js gzip	5.04 kB	5.04 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	242 B	243 B	N/A
main-HASH.js gzip	32.1 kB	32.2 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	45.4 kB	45.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tdanecker/next.js bug/export-crossorigin	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	tdanecker/next.js bug/export-crossorigin	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.2 kB	4.2 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.56 kB	6.56 kB	✓

Client Build Manifests

	vercel/next.js canary	tdanecker/next.js bug/export-crossorigin	Change
_buildManifest.js gzip	483 B	485 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	tdanecker/next.js bug/export-crossorigin	Change
index.html gzip	529 B	527 B	N/A
link.html gzip	541 B	541 B	✓
withRouter.html gzip	525 B	523 B	N/A
Overall change	541 B	541 B	✓

Edge SSR bundle Size

	vercel/next.js canary	tdanecker/next.js bug/export-crossorigin	Change
edge-ssr.js gzip	95 kB	95 kB	N/A
page.js gzip	3.06 kB	3.07 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	tdanecker/next.js bug/export-crossorigin	Change
middleware-b..fest.js gzip	623 B	622 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	990 B	990 B	✓

Next Runtimes

	vercel/next.js canary	tdanecker/next.js bug/export-crossorigin	Change
app-page-exp...dev.js gzip	171 kB	171 kB	✓
app-page-exp..prod.js gzip	96.7 kB	96.7 kB	✓
app-page-tur..prod.js gzip	98.5 kB	98.5 kB	✓
app-page-tur..prod.js gzip	92.9 kB	92.9 kB	✓
app-page.run...dev.js gzip	150 kB	150 kB	✓
app-page.run..prod.js gzip	91.4 kB	91.4 kB	✓
app-route-ex...dev.js gzip	21.3 kB	21.3 kB	✓
app-route-ex..prod.js gzip	15 kB	15 kB	✓
app-route-tu..prod.js gzip	15 kB	15 kB	✓
app-route-tu..prod.js gzip	14.8 kB	14.8 kB	✓
app-route.ru...dev.js gzip	20.9 kB	20.9 kB	✓
app-route.ru..prod.js gzip	14.7 kB	14.7 kB	✓
pages-api-tu..prod.js gzip	9.51 kB	9.51 kB	✓
pages-api.ru...dev.js gzip	9.79 kB	9.79 kB	✓
pages-api.ru..prod.js gzip	9.51 kB	9.51 kB	✓
pages-turbo...prod.js gzip	22.3 kB	22.3 kB	✓
pages.runtim...dev.js gzip	23 kB	23 kB	✓
pages.runtim..prod.js gzip	22.3 kB	22.3 kB	✓
server.runti..prod.js gzip	50.6 kB	50.6 kB	✓
Overall change	950 kB	950 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	tdanecker/next.js bug/export-crossorigin	Change
0.pack gzip	1.56 MB	1.56 MB	N/A
index.pack gzip	105 kB	105 kB	⚠️ +176 B
Overall change	105 kB	105 kB	⚠️ +176 B

Diff details

Diff for middleware.js

Diff too large to display

Commit: 43ee6b3