Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: add route context to the dynamic errors #61332

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 29, 2024

What

Given user infomation when the dynamic errors are thrown, e.g. bad cookies or headers usages. Now users can tell through the error information to see which pathname is broken, and trace down the usage.

before

Page couldn't be rendered statically because ...
This page needs to bail out of prerendering at this point because ...

after

Route /cookies couldn't be rendered statically because ...
Route /server needs to bail out of prerendering at this point because ...

Why

When you have multi pages in your app, such as 100+, and many page might uses these. This is hard to trace down where exactly the error is from

Closes NEXT-2283
Cloese NEXT-2265

@ijjk
Copy link
Member

ijjk commented Jan 29, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 29, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/add-missing-context-for-rendering Change
buildDuration 11.6s 11.7s ⚠️ +147ms
buildDurationCached 6.4s 4.9s N/A
nodeModulesSize 200 MB 200 MB ⚠️ +21 kB
nextStartRea..uration (ms) 420ms 433ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/add-missing-context-for-rendering Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.8 kB 29.9 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 237 B 239 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/add-missing-context-for-rendering Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/add-missing-context-for-rendering Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 502 B
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 608 B 608 B
Client Build Manifests
vercel/next.js canary vercel/next.js fix/add-missing-context-for-rendering Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/add-missing-context-for-rendering Change
index.html gzip 529 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 523 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix/add-missing-context-for-rendering Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 150 kB 150 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js fix/add-missing-context-for-rendering Change
middleware-b..fest.js gzip 623 B 622 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.6 kB 37.6 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 39.5 kB 39.5 kB
Next Runtimes
vercel/next.js canary vercel/next.js fix/add-missing-context-for-rendering Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.7 kB 95.7 kB
app-page-tur..prod.js gzip 96.4 kB 96.4 kB
app-page-tur..prod.js gzip 91 kB 91 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.3 kB 90.3 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB N/A
app-route-ex..prod.js gzip 14.9 kB 14.9 kB N/A
app-route-tu..prod.js gzip 14.9 kB 14.9 kB N/A
app-route-tu..prod.js gzip 14.5 kB 14.5 kB N/A
app-route.ru...dev.js gzip 21.6 kB 21.6 kB N/A
app-route.ru..prod.js gzip 14.5 kB 14.5 kB N/A
pages-api-tu..prod.js gzip 9.42 kB 9.42 kB
pages-api.ru...dev.js gzip 9.69 kB 9.69 kB
pages-api.ru..prod.js gzip 9.42 kB 9.42 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 830 kB 830 kB
Diff details
Diff for page.js

Diff too large to display

Diff for 68-HASH.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: 7271d26

@huozhi huozhi marked this pull request as ready for review January 29, 2024 16:15
@huozhi huozhi merged commit 3008af6 into canary Jan 29, 2024
68 checks passed
@huozhi huozhi deleted the fix/add-missing-context-for-rendering branch January 29, 2024 16:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants