-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use real font files for font tests #61399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForsakenHarmony
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
January 30, 2024 16:36
ijjk
added
Font (next/font)
Related to Next.js Font Optimization.
area: tests
created-by: Turbopack team
PRs by the Turbopack team.
labels
Jan 30, 2024
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
Failing test suitesCommit: 66fe135
Expand output● next/font/google with-font-declarations-file › preload correct files at /local-font
Read more about building and testing Next.js in contributing.md. |
timneutkens
approved these changes
Jan 30, 2024
ForsakenHarmony
force-pushed
the
hrmny/use-real-fonts
branch
3 times, most recently
from
January 31, 2024 01:02
d38bd5c
to
66fe135
Compare
ForsakenHarmony
force-pushed
the
hrmny/use-real-fonts
branch
from
January 31, 2024 01:12
66fe135
to
581f152
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Turbopack team
PRs by the Turbopack team.
Font (next/font)
Related to Next.js Font Optimization.
locked
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Turbopack throws a build error (next just logs an error).
Also probably better to test with real font files in general.
Closes PACK-2324