-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat(next/image)!: remove squoosh
in favor of sharp
as optional dep"
#61810
Merged
feedthejim
merged 1 commit into
canary
from
revert-61696-remove-squoosh-add-sharp-optionaldep
Feb 8, 2024
Merged
Revert "feat(next/image)!: remove squoosh
in favor of sharp
as optional dep"
#61810
feedthejim
merged 1 commit into
canary
from
revert-61696-remove-squoosh-add-sharp-optionaldep
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional d…" This reverts commit 07c4ec0.
feedthejim
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
a team,
ztanner,
styfle and
wyattjoh
as code owners
February 8, 2024 10:25
ijjk
added
area: documentation
created-by: Next.js team
PRs by the Next.js team.
type: next
labels
Feb 8, 2024
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
Diff detailsDiff for image-HASH.js@@ -1,7 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[358],
{
- /***/ 1552: /***/ function (
+ /***/ 4070: /***/ function (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
@@ -9,7 +9,7 @@
(window.__NEXT_P = window.__NEXT_P || []).push([
"/image",
function () {
- return __webpack_require__(2599);
+ return __webpack_require__(2369);
},
]);
if (false) {
@@ -18,7 +18,7 @@
/***/
},
- /***/ 9272: /***/ function (module, exports, __webpack_require__) {
+ /***/ 3299: /***/ function (module, exports, __webpack_require__) {
"use strict";
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
@@ -40,15 +40,15 @@
__webpack_require__(422)
);
const _head = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(8286)
+ __webpack_require__(4830)
);
- const _getimgprops = __webpack_require__(985);
- const _imageconfig = __webpack_require__(8749);
- const _imageconfigcontextsharedruntime = __webpack_require__(7829);
- const _warnonce = __webpack_require__(3652);
- const _routercontextsharedruntime = __webpack_require__(6120);
+ const _getimgprops = __webpack_require__(3301);
+ const _imageconfig = __webpack_require__(2958);
+ const _imageconfigcontextsharedruntime = __webpack_require__(6869);
+ const _warnonce = __webpack_require__(2179);
+ const _routercontextsharedruntime = __webpack_require__(7554);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(5732)
+ __webpack_require__(9687)
);
// This is replaced by webpack define plugin
const configEnv = {
@@ -373,7 +373,7 @@
/***/
},
- /***/ 985: /***/ function (
+ /***/ 3301: /***/ function (
__unused_webpack_module,
exports,
__webpack_require__
@@ -389,9 +389,9 @@
return getImgProps;
},
});
- const _warnonce = __webpack_require__(3652);
- const _imageblursvg = __webpack_require__(1668);
- const _imageconfig = __webpack_require__(8749);
+ const _warnonce = __webpack_require__(2179);
+ const _imageblursvg = __webpack_require__(892);
+ const _imageconfig = __webpack_require__(2958);
const VALID_LOADING_VALUES =
/* unused pure expression or super */ null && [
"lazy",
@@ -760,7 +760,7 @@
/***/
},
- /***/ 1668: /***/ function (__unused_webpack_module, exports) {
+ /***/ 892: /***/ function (__unused_webpack_module, exports) {
"use strict";
/**
* A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -815,7 +815,7 @@
/***/
},
- /***/ 9582: /***/ function (
+ /***/ 3612: /***/ function (
__unused_webpack_module,
exports,
__webpack_require__
@@ -842,10 +842,10 @@
},
});
const _interop_require_default = __webpack_require__(2430);
- const _getimgprops = __webpack_require__(985);
- const _imagecomponent = __webpack_require__(9272);
+ const _getimgprops = __webpack_require__(3301);
+ const _imagecomponent = __webpack_require__(3299);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(5732)
+ __webpack_require__(9687)
);
function getImageProps(imgProps) {
const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -877,7 +877,7 @@
/***/
},
- /***/ 5732: /***/ function (__unused_webpack_module, exports) {
+ /***/ 9687: /***/ function (__unused_webpack_module, exports) {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -912,7 +912,7 @@
/***/
},
- /***/ 2599: /***/ function (
+ /***/ 2369: /***/ function (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -933,15 +933,15 @@
// EXTERNAL MODULE: ./node_modules/.pnpm/react@18.2.0/node_modules/react/jsx-runtime.js
var jsx_runtime = __webpack_require__(1527);
- // EXTERNAL MODULE: ./node_modules/.pnpm/file+..+main-repo+packages+next+next-packed.tgz_react-dom@18.2.0_react@18.2.0/node_modules/next/image.js
- var next_image = __webpack_require__(1577);
+ // EXTERNAL MODULE: ./node_modules/.pnpm/file+..+diff-repo+packages+next+next-packed.tgz_react-dom@18.2.0_react@18.2.0/node_modules/next/image.js
+ var next_image = __webpack_require__(73);
var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
/* harmony default export */ var nextjs = {
src: "/_next/static/media/nextjs.cae0b805.png",
height: 1347,
width: 1626,
blurDataURL:
- "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAgAAAAHCAMAAAACh/xsAAAAD1BMVEX////x8fH6+vrb29vo6Oh8o70bAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAH0lEQVR4nGNgwARMjIyMjCAGCzMzMwsTRISJCcRABwAEcAAkLCQfgAAAAABJRU5ErkJggg==",
+ "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAgAAAAHCAAAAAAQMlOCAAAAMElEQVR42hXJOQ4AIBDDwPz/q9BRcG6MMpUlCweWCSPqnrWxmK33Ucjeq16CyHKYD8vhNzo5Br4tAAAAAElFTkSuQmCC",
blurWidth: 8,
blurHeight: 7,
}; // CONCATENATED MODULE: ./pages/image.js
@@ -964,12 +964,12 @@
/***/
},
- /***/ 1577: /***/ function (
+ /***/ 73: /***/ function (
module,
__unused_webpack_exports,
__webpack_require__
) {
- module.exports = __webpack_require__(9582);
+ module.exports = __webpack_require__(3612);
/***/
},
@@ -980,7 +980,7 @@
return __webpack_require__((__webpack_require__.s = moduleId));
};
/******/ __webpack_require__.O(0, [888, 774, 179], function () {
- return __webpack_exec__(1552);
+ return __webpack_exec__(4070);
});
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__; |
huozhi
approved these changes
Feb 8, 2024
huozhi
approved these changes
Feb 8, 2024
timneutkens
approved these changes
Feb 8, 2024
feedthejim
deleted the
revert-61696-remove-squoosh-add-sharp-optionaldep
branch
February 8, 2024 11:00
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #61696 since it was failing with
yarn@1
Closes NEXT-2401