-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(next/image): improve warning when fill
and sizes="100vw"
#61949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
ztanner and
a team
as code owners
February 12, 2024 16:20
styfle
requested review from
timeyoutakeit and
molebox
and removed request for
a team
February 12, 2024 16:20
ijjk
added
area: tests
created-by: Next.js team
PRs by the Next.js team.
type: next
labels
Feb 12, 2024
Failing test suitesCommit: 96beaaf
Expand output● CLI Usage › dev › NODE_OPTIONS='--inspect'
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault BuildGeneral Overall increase
|
vercel/next.js canary | vercel/next.js styfle/next-2441-fix-warning-sizes-prop | Change | |
---|---|---|---|
buildDuration | 11.7s | 11.8s | N/A |
buildDurationCached | 6.3s | 4.9s | N/A |
nodeModulesSize | 196 MB | 196 MB | |
nextStartRea..uration (ms) | 428ms | 429ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js styfle/next-2441-fix-warning-sizes-prop | Change | |
---|---|---|---|
3f784ff6-HASH.js gzip | 53.5 kB | 53.5 kB | N/A |
423.HASH.js gzip | 185 B | 181 B | N/A |
68-HASH.js gzip | 29.6 kB | 29.6 kB | N/A |
framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
main-app-HASH.js gzip | 238 B | 239 B | N/A |
main-HASH.js gzip | 31.9 kB | 31.9 kB | N/A |
webpack-HASH.js gzip | 1.7 kB | 1.7 kB | ✓ |
Overall change | 46.9 kB | 46.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js styfle/next-2441-fix-warning-sizes-prop | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js styfle/next-2441-fix-warning-sizes-prop | Change | |
---|---|---|---|
_app-HASH.js gzip | 194 B | 195 B | N/A |
_error-HASH.js gzip | 182 B | 181 B | N/A |
amp-HASH.js gzip | 502 B | 501 B | N/A |
css-HASH.js gzip | 320 B | 322 B | N/A |
dynamic-HASH.js gzip | 2.5 kB | 2.5 kB | N/A |
edge-ssr-HASH.js gzip | 255 B | 256 B | N/A |
head-HASH.js gzip | 350 B | 349 B | N/A |
hooks-HASH.js gzip | 368 B | 369 B | N/A |
image-HASH.js gzip | 4.19 kB | 4.2 kB | N/A |
index-HASH.js gzip | 257 B | 256 B | N/A |
link-HASH.js gzip | 2.67 kB | 2.67 kB | N/A |
routerDirect..HASH.js gzip | 310 B | 311 B | N/A |
script-HASH.js gzip | 384 B | 383 B | N/A |
withRouter-HASH.js gzip | 306 B | 308 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 106 B | 106 B | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js styfle/next-2441-fix-warning-sizes-prop | Change | |
---|---|---|---|
_buildManifest.js gzip | 483 B | 484 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js styfle/next-2441-fix-warning-sizes-prop | Change | |
---|---|---|---|
index.html gzip | 528 B | 527 B | N/A |
link.html gzip | 541 B | 539 B | N/A |
withRouter.html gzip | 523 B | 522 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js styfle/next-2441-fix-warning-sizes-prop | Change | |
---|---|---|---|
edge-ssr.js gzip | 94.4 kB | 94.4 kB | N/A |
page.js gzip | 150 kB | 150 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js styfle/next-2441-fix-warning-sizes-prop | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 619 B | 624 B | N/A |
middleware-r..fest.js gzip | 151 B | 149 B | N/A |
middleware.js gzip | 47.4 kB | 47.4 kB | N/A |
edge-runtime..pack.js gzip | 1.94 kB | 1.94 kB | ✓ |
Overall change | 1.94 kB | 1.94 kB | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js styfle/next-2441-fix-warning-sizes-prop | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 166 kB | 166 kB | ✓ |
app-page-exp..prod.js gzip | 95.4 kB | 95.4 kB | ✓ |
app-page-tur..prod.js gzip | 97.2 kB | 97.2 kB | ✓ |
app-page-tur..prod.js gzip | 91.6 kB | 91.6 kB | ✓ |
app-page.run...dev.js gzip | 136 kB | 136 kB | ✓ |
app-page.run..prod.js gzip | 90.2 kB | 90.2 kB | ✓ |
app-route-ex...dev.js gzip | 22 kB | 22 kB | ✓ |
app-route-ex..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
app-route-tu..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
app-route-tu..prod.js gzip | 14.7 kB | 14.7 kB | ✓ |
app-route.ru...dev.js gzip | 21.7 kB | 21.7 kB | ✓ |
app-route.ru..prod.js gzip | 14.7 kB | 14.7 kB | ✓ |
pages-api-tu..prod.js gzip | 9.43 kB | 9.43 kB | ✓ |
pages-api.ru...dev.js gzip | 9.7 kB | 9.7 kB | ✓ |
pages-api.ru..prod.js gzip | 9.43 kB | 9.43 kB | ✓ |
pages-turbo...prod.js gzip | 22 kB | 22 kB | ✓ |
pages.runtim...dev.js gzip | 22.7 kB | 22.7 kB | ✓ |
pages.runtim..prod.js gzip | 22 kB | 22 kB | ✓ |
server.runti..prod.js gzip | 49.9 kB | 49.9 kB | ✓ |
Overall change | 924 kB | 924 kB | ✓ |
Diff details
Diff for image-HASH.js
@@ -1,7 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[358],
{
- /***/ 1552: /***/ function (
+ /***/ 4070: /***/ function (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
@@ -9,7 +9,7 @@
(window.__NEXT_P = window.__NEXT_P || []).push([
"/image",
function () {
- return __webpack_require__(2599);
+ return __webpack_require__(2369);
},
]);
if (false) {
@@ -18,7 +18,7 @@
/***/
},
- /***/ 9272: /***/ function (module, exports, __webpack_require__) {
+ /***/ 3299: /***/ function (module, exports, __webpack_require__) {
"use strict";
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
@@ -40,15 +40,15 @@
__webpack_require__(422)
);
const _head = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(8286)
+ __webpack_require__(4830)
);
- const _getimgprops = __webpack_require__(985);
- const _imageconfig = __webpack_require__(8749);
- const _imageconfigcontextsharedruntime = __webpack_require__(7829);
- const _warnonce = __webpack_require__(3652);
- const _routercontextsharedruntime = __webpack_require__(6120);
+ const _getimgprops = __webpack_require__(3301);
+ const _imageconfig = __webpack_require__(2958);
+ const _imageconfigcontextsharedruntime = __webpack_require__(6869);
+ const _warnonce = __webpack_require__(2179);
+ const _routercontextsharedruntime = __webpack_require__(7554);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(5732)
+ __webpack_require__(9687)
);
// This is replaced by webpack define plugin
const configEnv = {
@@ -69,7 +69,8 @@
onLoadRef,
onLoadingCompleteRef,
setBlurComplete,
- unoptimized
+ unoptimized,
+ sizesInput
) {
const src = img == null ? void 0 : img.src;
if (!img || img["data-loaded-src"] === src) {
@@ -165,6 +166,7 @@
onLoadingCompleteRef,
setBlurComplete,
setShowAltText,
+ sizesInput,
onLoad,
onError,
...rest
@@ -219,7 +221,8 @@
onLoadRef,
onLoadingCompleteRef,
setBlurComplete,
- unoptimized
+ unoptimized,
+ sizesInput
);
}
},
@@ -231,6 +234,7 @@
setBlurComplete,
onError,
unoptimized,
+ sizesInput,
forwardedRef,
]
),
@@ -242,7 +246,8 @@
onLoadRef,
onLoadingCompleteRef,
setBlurComplete,
- unoptimized
+ unoptimized,
+ sizesInput
);
},
onError: (event) => {
@@ -346,6 +351,7 @@
onLoadingCompleteRef: onLoadingCompleteRef,
setBlurComplete: setBlurComplete,
setShowAltText: setShowAltText,
+ sizesInput: props.sizes,
ref: forwardedRef,
}),
imgMeta.priority
@@ -373,7 +379,7 @@
/***/
},
- /***/ 985: /***/ function (
+ /***/ 3301: /***/ function (
__unused_webpack_module,
exports,
__webpack_require__
@@ -389,9 +395,9 @@
return getImgProps;
},
});
- const _warnonce = __webpack_require__(3652);
- const _imageblursvg = __webpack_require__(1668);
- const _imageconfig = __webpack_require__(8749);
+ const _warnonce = __webpack_require__(2179);
+ const _imageblursvg = __webpack_require__(892);
+ const _imageconfig = __webpack_require__(2958);
const VALID_LOADING_VALUES =
/* unused pure expression or super */ null && [
"lazy",
@@ -760,7 +766,7 @@
/***/
},
- /***/ 1668: /***/ function (__unused_webpack_module, exports) {
+ /***/ 892: /***/ function (__unused_webpack_module, exports) {
"use strict";
/**
* A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -815,7 +821,7 @@
/***/
},
- /***/ 9582: /***/ function (
+ /***/ 3612: /***/ function (
__unused_webpack_module,
exports,
__webpack_require__
@@ -842,10 +848,10 @@
},
});
const _interop_require_default = __webpack_require__(2430);
- const _getimgprops = __webpack_require__(985);
- const _imagecomponent = __webpack_require__(9272);
+ const _getimgprops = __webpack_require__(3301);
+ const _imagecomponent = __webpack_require__(3299);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(5732)
+ __webpack_require__(9687)
);
function getImageProps(imgProps) {
const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -877,7 +883,7 @@
/***/
},
- /***/ 5732: /***/ function (__unused_webpack_module, exports) {
+ /***/ 9687: /***/ function (__unused_webpack_module, exports) {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -912,7 +918,7 @@
/***/
},
- /***/ 2599: /***/ function (
+ /***/ 2369: /***/ function (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -933,8 +939,8 @@
// EXTERNAL MODULE: ./node_modules/.pnpm/react@18.2.0/node_modules/react/jsx-runtime.js
var jsx_runtime = __webpack_require__(1527);
- // EXTERNAL MODULE: ./node_modules/.pnpm/file+..+main-repo+packages+next+next-packed.tgz_react-dom@18.2.0_react@18.2.0/node_modules/next/image.js
- var next_image = __webpack_require__(1577);
+ // EXTERNAL MODULE: ./node_modules/.pnpm/file+..+diff-repo+packages+next+next-packed.tgz_react-dom@18.2.0_react@18.2.0/node_modules/next/image.js
+ var next_image = __webpack_require__(73);
var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
/* harmony default export */ var nextjs = {
src: "/_next/static/media/nextjs.cae0b805.png",
@@ -964,12 +970,12 @@
/***/
},
- /***/ 1577: /***/ function (
+ /***/ 73: /***/ function (
module,
__unused_webpack_exports,
__webpack_require__
) {
- module.exports = __webpack_require__(9582);
+ module.exports = __webpack_require__(3612);
/***/
},
@@ -980,7 +986,7 @@
return __webpack_require__((__webpack_require__.s = moduleId));
};
/******/ __webpack_require__.O(0, [888, 774, 179], function () {
- return __webpack_exec__(1552);
+ return __webpack_exec__(4070);
});
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;
1 task
ijjk
approved these changes
Feb 12, 2024
deployed? |
@Nhahan Yes, see v14.1.1-canary.49. You can try it out today with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this error was confusing because it made it sound like the
sizes
prop was missing. This was because the default value ofsizes
is100vw
so the previous code couldn't tell the different between implicit vs explicit100vw
.This PR changes the code to read the input value from the
sizes
prop and prints a better warning.Fixes NEXT-2441
Fixes #58586