Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 2 #62147

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Patch 2 #62147

merged 5 commits into from
Feb 16, 2024

Conversation

mnjongerius
Copy link
Contributor

What?

Updating Example for Storyblok

Why?

While setting up the Storyblok example to do create quick poc I noticed some documentation missing and some code not working as expected.

How?

  • Updates documentation about Storyblok example in README
  • Code change in HeroPost to make Storyblok example work as expected

Describing the fields for post content-type
Fix slug prop for CoverImage
Add step for Configure Image Optimization
@mnjongerius mnjongerius requested review from a team as code owners February 16, 2024 13:37
@mnjongerius mnjongerius requested review from ismaelrumzan and molebox and removed request for a team February 16, 2024 13:37
@ijjk ijjk added the examples Issue was opened via the examples template. label Feb 16, 2024
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@samcx samcx enabled auto-merge (squash) February 16, 2024 20:11
@ijjk
Copy link
Member

ijjk commented Feb 16, 2024

Allow CI Workflow Run

  • approve CI run for commit: 0a22a8b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx samcx merged commit 895e7df into vercel:canary Feb 16, 2024
31 checks passed
@github-actions github-actions bot added the locked label Mar 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants