Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update unstable_cache.mdx with important info about dynamic data #62202

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

meenie
Copy link
Contributor

@meenie meenie commented Feb 17, 2024

What?

This caused me a ton of issues in production due to inconsistent cache. It does not manifest itself in local development. The only reason I figured it out was because I upgraded to the canary release and someone added a helpful exception explaining that I shouldn't be doing what I was doing. To hopefully help people in the future, I'm adding a blurb to the unstable_cache docs.

@meenie meenie requested review from a team as code owners February 17, 2024 22:01
@meenie meenie requested review from jh3y and leerob and removed request for a team February 17, 2024 22:01
@ijjk
Copy link
Member

ijjk commented Feb 17, 2024

Allow CI Workflow Run

  • approve CI run for commit: ecbe787

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@meenie meenie changed the title Update unstable_cache.mdx with important info about dynamic data Docs: Update unstable_cache.mdx with important info about dynamic data Feb 17, 2024
@meenie meenie changed the title Docs: Update unstable_cache.mdx with important info about dynamic data docs: Update unstable_cache.mdx with important info about dynamic data Feb 17, 2024
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@samcx samcx enabled auto-merge (squash) February 20, 2024 17:50
@samcx samcx merged commit fb99d2e into vercel:canary Feb 20, 2024
31 checks passed
@meenie meenie deleted the patch-2 branch February 21, 2024 03:27
@github-actions github-actions bot added the locked label Mar 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants